Support log pattern if there is dsl and index passed for alert summary. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Signed-off-by: Heng Qian <qianheng@amazon.com>
ruanyl
reviewed
Sep 30, 2024
| let result = response.body.inference_results[0].output[0].result; | ||
| result = JSON.parse(result).output.text; | ||
| return res.ok({ body: result }); | ||
| return res.ok({ body: response.body.inference_results[0].output[0].result }); |
There was a problem hiding this comment.
So both agents(tools): LOG_PATTERN_SUMMARY_AGENT_CONFIG_ID and SUMMARY_AGENT_CONFIG_ID has changed the output from plain text to json?
Never mind, it seems the output structure changed
There was a problem hiding this comment.
Yeah. Only os_insight agent has change its output structure from json to text. Because there is a post function added in connector:
"post_process_function": "return params.output.text;"
ruanyl
approved these changes
Sep 30, 2024
xluo-aws
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…y. (#339) * Support log pattern if there is dsl and index passed for alert summary. Signed-off-by: Heng Qian <qianheng@amazon.com> * Add CHANGELOG.md Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit 5c32cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
xluo-aws
pushed a commit
that referenced
this pull request
Sep 30, 2024
…y. (#339) (#340) * Support log pattern if there is dsl and index passed for alert summary. Signed-off-by: Heng Qian <qianheng@amazon.com> * Add CHANGELOG.md Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit 5c32cca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support log pattern feature. It will use agent
os_summary_with_logPatternif there is parameterdslandindexpassed.Other minor change includes:
outputdirectly due to flow framework script change.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.