refactor(t2viz): register the AI actions to query controls in discover #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
lezzago,
joshuali925,
anirudha,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
update-ai-actions-menu
branch
from
fe52587
to
79e3dde
Compare
Hailong-am
approved these changes
Sep 26, 2024
Hailong-am
reviewed
Sep 26, 2024
| aria-label="AI assistant trigger button" | ||
| size="s" | ||
| iconType={assistantTriggerIcon} | ||
| size="xs" |
There was a problem hiding this comment.
maybe we should keep it as s to align with DQL
There was a problem hiding this comment.
having an alignment issue now when changed to a s button, this requires a css tweaks in core, I will keep as is now.
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
#327) * refactor(t2viz): register the AI actions to query controls in discover Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * add changelogs Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove default of config entry branding.label Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 9930241) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Sep 27, 2024
#327) (#328) * refactor(t2viz): register the AI actions to query controls in discover Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * add changelogs Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove default of config entry branding.label Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 9930241) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
added a commit
to ruanyl/dashboards-assistant
that referenced
this pull request
Sep 27, 2024
opensearch-project#327) * refactor(t2viz): register the AI actions to query controls in discover Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * add changelogs Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove default of config entry branding.label Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.