Refactor find last methods #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 95.31% 95.34% +0.02%
==========================================
Files 47 48 +1
Lines 1260 1268 +8
Branches 304 306 +2
==========================================
+ Hits 1201 1209 +8
Misses 57 57
Partials 2 2 ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
raintygao
as code owners
Hailong-am
reviewed
Jan 26, 2024
| const index = [...array].reverse().findIndex(predicate); | ||
| if (index === -1) { | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
why don't just search from last element to first?
There was a problem hiding this comment.
Is that means write a for loop to search from end to start?
There was a problem hiding this comment.
Yes, that sounds like more straightforward and no additional array copy and reverse
There was a problem hiding this comment.
Make sense, will update later.
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
approved these changes
Jan 29, 2024
Hailong-am
approved these changes
Jan 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* refactor: replace findLast with find and reverse Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: replace Array.prototype.findLastIndex with findLastIndex Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor findLastIndex with for loop Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit e7b810e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
wanglam
pushed a commit
that referenced
this pull request
Jan 29, 2024
* refactor: replace findLast with find and reverse * refactor: replace Array.prototype.findLastIndex with findLastIndex * refactor findLastIndex with for loop --------- (cherry picked from commit e7b810e) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Find last related methods was added in TC39, it can't be used in some old browsers. The FT for electron 94 in FT repo will be failed due to these methods. Refactor to reverse and find.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.