-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up workflow to install plugins #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
seraphjiang
reviewed
Oct 25, 2022
seraphjiang
approved these changes
Oct 25, 2022
seraphjiang
reviewed
Oct 25, 2022
seraphjiang
reviewed
Oct 25, 2022
seraphjiang
reviewed
Oct 25, 2022
s_keys.add(kv[0]) | ||
|
||
nt = [] | ||
with open(target_file, "r") as t: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
with open(target_file, "r") as t: | |
with open(TARGET_FILE, "r") as t: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, changed to use uppercase for constants in new commit
seraphjiang
reviewed
Oct 25, 2022
Signed-off-by: Lu Yu <nluyu@amazon.com>
seraphjiang
requested review from
Flyingliuhub,
zhongnansu,
kristenTian and
ZilongX
October 25, 2022 17:51
ZilongX
reviewed
Oct 25, 2022
kristenTian
approved these changes
Oct 25, 2022
ZilongX
reviewed
Oct 26, 2022
ZilongX
reviewed
Oct 26, 2022
…heck file exist before updating config Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
seraphjiang
approved these changes
Oct 26, 2022
…cking id when install chart Signed-off-by: Lu Yu <nluyu@amazon.com>
2 tasks
Flyingliuhub
approved these changes
Oct 28, 2022
Signed-off-by: Lu Yu <nluyu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lu Yu nluyu@amazon.com
Description
This change
Issues Resolved
#86
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.