Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up workflow to install plugins #91

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Oct 25, 2022

Signed-off-by: Lu Yu nluyu@amazon.com

Description

This change

  • creates a new github action workflow to be triggered manually at this moment but subject to change when we have UI integration, the workflow inserts settings into addition config to be inserted into the configuration yaml file, and also gets plugins to be installed from github settings and builds and push docker image based on contents within the config/playground/docker/dev folder. The docker credentials, repo and tags are passed from secrets stored in github
  • creates a custom_osd_entry script to be used to override the cmd of the official image
  • adds custom dockerfile using latest official image as base image - this can be improved once we have UI integration to allow users to select which base image to use
  • creates a install-plugins script to install plugins based on arguments
  • removed config which will override whatever changes we made at this moment, and we can't expose the tracking id config in the yaml due to sensitivity of the data, thus the tracking id is written into the yaml on demand

Issues Resolved

#86

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lu Yu <nluyu@amazon.com>
@seraphjiang seraphjiang added enhancement New feature or request v1.0.0 labels Oct 25, 2022
@seraphjiang seraphjiang requested a review from a team October 25, 2022 07:05
s_keys.add(kv[0])

nt = []
with open(target_file, "r") as t:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with open(target_file, "r") as t:
with open(TARGET_FILE, "r") as t:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, changed to use uppercase for constants in new commit

Signed-off-by: Lu Yu <nluyu@amazon.com>
…heck file exist before updating config

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
…cking id when install chart

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
@BionIT BionIT merged commit a0b0b40 into opensearch-project:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants