Resolve dependency issues between jar and zip maven publications #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
andrross,
reta and
nknize
as code owners
|
Results: |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
andrross
reviewed
Sep 9, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
andrross
approved these changes
Sep 9, 2023
andrross
reviewed
Sep 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2023
* Resolve dependency issues between jar and zip maven publications Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Tweak typo Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 64e4332) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2023
* Resolve dependency issues between jar and zip maven publications Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Tweak typo Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 64e4332) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Yes, that is by design so group vs groupid is different here. |
peterzhuamazon
deleted the
update-jarzip-gradle-maven-publishing-dependencies
branch
This was referenced Sep 9, 2023
andrross
pushed a commit
that referenced
this pull request
Sep 9, 2023
#41) * Resolve dependency issues between jar and zip maven publications * Remove comments * Tweak typo --------- (cherry picked from commit 64e4332) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Sep 9, 2023
#40) * Resolve dependency issues between jar and zip maven publications * Remove comments * Tweak typo --------- (cherry picked from commit 64e4332) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve dependency issues between jar and zip maven publications
Issues Resolved
opensearch-project/opensearch-build#3743
Closes #38
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.