[Backport 2.0] Updating filters as well during Alias update (#491) #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing : Integ Test, Local Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ankitkala
approved these changes
Aug 26, 2022
soosinha
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing : Integ Test, Local
Signed-off-by: Gaurav Bafna gbbafna@amazon.com
Description
Alias filter changes aren't getting replicated to follower cluster.
On inspecting code, the logic to replicate alias is missing code to replicate filter. This results in inconsistent alias on the follower end whenever an alias filter is updated.
This change adds the logic to copy the filters as well . I have also verified that there is no other alias metadata we are missing.
Issues Resolved
#490
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.