Skip to content

Conversation

@gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Aug 24, 2022

Testing : Integ Test, Local
Signed-off-by: Gaurav Bafna gbbafna@amazon.com

Description

Alias filter changes aren't getting replicated to follower cluster.

On inspecting code, the logic to replicate alias is missing code to replicate filter. This results in inconsistent alias on the follower end whenever an alias filter is updated.

This change adds the logic to copy the filters as well . I have also verified that there is no other alias metadata we are missing.

Issues Resolved

#490

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Testing : Integ Test, Local
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@gbbafna gbbafna requested a review from a team August 24, 2022 06:30
@codecov-commenter
Copy link

Codecov Report

Merging #499 (83dfd29) into 2.x (e0b9002) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #499      +/-   ##
============================================
- Coverage     72.83%   72.41%   -0.42%     
+ Complexity      984      979       -5     
============================================
  Files           141      141              
  Lines          4576     4579       +3     
  Branches        506      507       +1     
============================================
- Hits           3333     3316      -17     
- Misses          927      940      +13     
- Partials        316      323       +7     
Impacted Files Coverage Δ
...rch/replication/task/index/IndexReplicationTask.kt 67.81% <100.00%> (-0.24%) ⬇️
...arch/replication/metadata/UpdateMetadataRequest.kt 77.27% <0.00%> (-22.73%) ⬇️
...cation/action/changes/TransportGetChangesAction.kt 63.49% <0.00%> (-20.64%) ⬇️
...earch/replication/metadata/UpdateIndexBlockTask.kt 74.19% <0.00%> (-3.23%) ⬇️
...arch/replication/task/autofollow/AutoFollowTask.kt 70.94% <0.00%> (-1.36%) ⬇️
.../action/status/TransportReplicationStatusAction.kt 96.73% <0.00%> (-1.09%) ⬇️
...action/stop/TransportStopIndexReplicationAction.kt 73.33% <0.00%> (+5.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gbbafna gbbafna enabled auto-merge (squash) August 26, 2022 05:09
@gbbafna gbbafna merged commit 9df9639 into opensearch-project:2.x Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants