Skip to content

Conversation

@Rishikesh1159
Copy link
Member

Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com

Description

This PR replaces "leader_cluster" with "leader_alias" in readme file.

Issues Resolved

#452

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@Rishikesh1159 Rishikesh1159 requested a review from a team July 18, 2022 07:13
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #453 (3070edd) into main (6130d6f) will decrease coverage by 0.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #453      +/-   ##
============================================
- Coverage     74.63%   74.17%   -0.47%     
+ Complexity     1006     1001       -5     
============================================
  Files           141      141              
  Lines          4565     4565              
  Branches        504      504              
============================================
- Hits           3407     3386      -21     
- Misses          841      858      +17     
- Partials        317      321       +4     
Impacted Files Coverage Δ
...rch/replication/action/status/ShardInfoResponse.kt 72.26% <0.00%> (-19.33%) ⬇️
...rch/replication/task/index/IndexReplicationTask.kt 71.06% <0.00%> (-0.24%) ⬇️
...arch/replication/task/autofollow/AutoFollowTask.kt 74.32% <0.00%> (+1.35%) ⬆️
...ation/task/shard/ShardReplicationChangesTracker.kt 63.63% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6130d6f...3070edd. Read the comment docs.

@ankitkala ankitkala merged commit 08ad60b into opensearch-project:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants