Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated security CI workflow to build security plugin via Gradle #309

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Feb 21, 2022

Description

Updated security CI workflow to build security plugin via Gradle

Issues Resolved

#308

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saikaranam-amazon saikaranam-amazon requested a review from a team February 21, 2022 06:06
@saikaranam-amazon saikaranam-amazon marked this pull request as draft February 21, 2022 06:19
@codecov-commenter
Copy link

Codecov Report

Merging #309 (6ce045e) into main (989f705) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
- Coverage     71.94%   71.79%   -0.16%     
- Complexity      893      894       +1     
============================================
  Files           139      139              
  Lines          4424     4424              
  Branches        520      520              
============================================
- Hits           3183     3176       -7     
- Misses          919      924       +5     
- Partials        322      324       +2     
Impacted Files Coverage Δ
...rch/replication/action/status/ShardInfoResponse.kt 74.78% <0.00%> (-18.27%) ⬇️
...action/stop/TransportStopIndexReplicationAction.kt 70.00% <0.00%> (-5.72%) ⬇️
...ation/task/shard/ShardReplicationChangesTracker.kt 60.60% <0.00%> (-3.04%) ⬇️
...replication/metadata/ReplicationMetadataManager.kt 64.28% <0.00%> (-1.03%) ⬇️
...on/resume/TransportResumeIndexReplicationAction.kt 85.29% <0.00%> (+1.47%) ⬆️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (+1.66%) ⬆️
...cation/action/changes/TransportGetChangesAction.kt 81.66% <0.00%> (+21.66%) ⬆️
...arch/replication/metadata/UpdateMetadataRequest.kt 100.00% <0.00%> (+23.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989f705...6ce045e. Read the comment docs.

@saikaranam-amazon saikaranam-amazon force-pushed the main-security-ci-update branch 2 times, most recently from 07780b9 to 24c3977 Compare February 21, 2022 09:17
@saikaranam-amazon saikaranam-amazon removed the request for review from a team February 21, 2022 09:17
@saikaranam-amazon saikaranam-amazon force-pushed the main-security-ci-update branch 4 times, most recently from 732c189 to 16c9feb Compare February 23, 2022 03:55
Signed-off-by: Sai Kumar <karanas@amazon.com>
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikaranam-amazon saikaranam-amazon merged commit 321b3f9 into opensearch-project:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants