Skip to content

Conversation

@aggarwalShivani
Copy link
Contributor

Description

Backport of #1391 on 2.x branch. Pls see the PR on main branch for complete background.
Mainly, the changes are ->

  • StopIndexReplicationAction and StopIndexReplicationRequest are moved from the ccr project to common-utils. (Common-utils change PR)
  • Added a new transport action, TransportInternalStopIndexReplicationAction - that can be used by other plugins like ism, to invoke stop-replication.

Related Issues

Stop replication feature in ism

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
@aggarwalShivani
Copy link
Contributor Author

Currently, CI checks are failing as required changes in common-utils PR are not yet merged.

@aggarwalShivani
Copy link
Contributor Author

Hi @ankitkala

Looks like, unlike other plugins, the ccr plugin zipfiles do not get published anymore at this link -
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-cross-cluster-replication, even though i see build.sh has the publish task.

Can you pls guide here on what is missing?

As part of this feature, we want to install ccr-plugin during integTest stage in ism plugin. Pls see for reference. Pls guide on how this can be achieved.

@aggarwalShivani
Copy link
Contributor Author

Hi @ankitkala

Looks like, unlike other plugins, the ccr plugin zipfiles do not get published anymore at this link - https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-cross-cluster-replication, even though i see build.sh has the publish task.

Can you pls guide here on what is missing?

Hi @ankitkala
Any suggestions here?

Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"indices:admin/plugins/replication/index/pause",
"indices:admin/plugins/replication/index/resume",
"indices:admin/plugins/replication/index/stop",
"$STOP_REPLICATION_ACTION_NAME",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, if user wants to use CCR in ISM in a security enabled cluster, they will still need the internal replication action allowed, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats right !

For current ccr users, no change - they can continue to use roles like cross_cluster_replication_follower_full_access for all ccr operations.
For users who use ccr + ism, they'll additionally need permission for the internal replication action indices:internal/plugins/replication/index/stop

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
@ankitkala ankitkala enabled auto-merge (rebase) March 5, 2025 09:18
@ankitkala ankitkala merged commit e4761c0 into opensearch-project:2.x Mar 5, 2025
14 checks passed
@aggarwalShivani aggarwalShivani deleted the commonutils-migr-2.x branch March 5, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants