-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added common utils for microsoft teams #374
Added common utils for microsoft teams #374
Conversation
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Hi @dankyalo599 Are we still working on this PR? Looks like the workflow checks failed. Can we address this in the meantime while I get some attention on the review. |
There are ktlint errors that need to be fixed |
Yes we are still working on this PR |
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
*/ | ||
data class MicrosoftTeams( | ||
val url: String | ||
>>>>>>> b13bf3d337f15337a3c6999c5285482a79fd5a5d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have code merge conflicts here.
Hi, I create a new PR to fix the build and add more test case. PR in notifications: opensearch-project/notifications#676 |
Looks like this was covered by #428. Closing, please reopen if I misunderstood |
Description
Add common utils for microsoft teams
Issues Resolved
Add class and unit tests for microsoft teams common utils
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.