Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshot to maven #252

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Arpit-Bandejiya
Copy link
Collaborator

@Arpit-Bandejiya Arpit-Bandejiya commented Mar 8, 2023

Description

Describe what this change achieves.

Issues Resolved

#239
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Arpit-Bandejiya Arpit-Bandejiya requested a review from a team as a code owner March 8, 2023 08:26
@Arpit-Bandejiya Arpit-Bandejiya requested a review from gaiksaya March 8, 2023 08:26
@Arpit-Bandejiya
Copy link
Collaborator Author

@gaiksaya can you help in creating the roles? Also when I'm trying to build locally using snapshots in URL I'm seeing the following:

> Task :publishPluginZipPublicationToSnapshotsRepository FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':publishPluginZipPublicationToSnapshotsRepository'.
> Failed to publish publication 'pluginZip' to repository 'Snapshots'
   > Authentication scheme 'all'(Authentication) is not supported by protocol 'file'


@gaiksaya
Copy link
Member

gaiksaya commented Mar 8, 2023

@gaiksaya can you help in creating the roles? Also when I'm trying to build locally using snapshots in URL I'm seeing the following:

> Task :publishPluginZipPublicationToSnapshotsRepository FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':publishPluginZipPublicationToSnapshotsRepository'.
> Failed to publish publication 'pluginZip' to repository 'Snapshots'
   > Authentication scheme 'all'(Authentication) is not supported by protocol 'file'

Check if the tasks exists ./gradlew tasks --all | grep snapshots. Check the issue for testing details on how to test on your local.

@Arpit-Bandejiya
Copy link
Collaborator Author

Testing:

abandeji@bcd074462b7f asynchronous-search % find snapshots | sort                                     
snapshots
snapshots/org
snapshots/org/opensearch
snapshots/org/opensearch/plugin
snapshots/org/opensearch/plugin/asynchronous-search
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.pom
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.pom.md5
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.pom.sha1
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.pom.sha256
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.pom.sha512
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.zip
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.zip.md5
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.zip.sha1
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.zip.sha256
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/asynchronous-search-2.6.0.0-20230310.123358-1.zip.sha512
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/maven-metadata.xml
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/asynchronous-search/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha512
snapshots/org/opensearch/plugin/asynchronous-search/maven-metadata.xml
snapshots/org/opensearch/plugin/asynchronous-search/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/asynchronous-search/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/asynchronous-search/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/asynchronous-search/maven-metadata.xml.sha512

@Arpit-Bandejiya
Copy link
Collaborator Author

#248 needs to be merged to fix the tests

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@09fdb40). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head dc5aa0d differs from pull request most recent head fa666d2. Consider uploading reports for the commit fa666d2 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage        ?   83.70%           
  Complexity      ?      558           
=======================================
  Files           ?       61           
  Lines           ?     2050           
  Branches        ?      146           
=======================================
  Hits            ?     1716           
  Misses          ?      229           
  Partials        ?      105           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Arpit-Bandejiya
Copy link
Collaborator Author

@gaiksaya please take a look

@dhruv16dhr dhruv16dhr self-requested a review March 17, 2023 15:22
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added PUBLISH_SNAPSHOTS_ROLE secret.

push:
branches:
- 'main'
- '1.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is not present for 1.x version. @prudhvigodithi can confirm but it can be removed later is required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gaiksaya you are right it should be starting from 2.x.

@Arpit-Bandejiya Arpit-Bandejiya merged commit 389b816 into opensearch-project:main Mar 17, 2023
@Arpit-Bandejiya Arpit-Bandejiya added the backport 2.x backport to 2.x label Mar 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
(cherry picked from commit 389b816)
@Arpit-Bandejiya Arpit-Bandejiya added backport 2.x backport to 2.x and removed backport 2.x backport to 2.x labels Mar 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2023
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
(cherry picked from commit 389b816)
@Arpit-Bandejiya Arpit-Bandejiya added backport 2.x backport to 2.x and removed backport 2.x backport to 2.x labels Mar 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2023
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
(cherry picked from commit 389b816)
@Arpit-Bandejiya Arpit-Bandejiya added backport 2.x backport to 2.x and removed backport 2.x backport to 2.x labels Mar 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
(cherry picked from commit 389b816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants