-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish snapshot to maven #252
Publish snapshot to maven #252
Conversation
@gaiksaya can you help in creating the roles? Also when I'm trying to build locally using snapshots in URL I'm seeing the following:
|
Check if the tasks exists |
Testing:
|
#248 needs to be merged to fix the tests |
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
12ad612
to
fa666d2
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage ? 83.70%
Complexity ? 558
=======================================
Files ? 61
Lines ? 2050
Branches ? 146
=======================================
Hits ? 1716
Misses ? 229
Partials ? 105 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@gaiksaya please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added PUBLISH_SNAPSHOTS_ROLE
secret.
push: | ||
branches: | ||
- 'main' | ||
- '1.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task is not present for 1.x version. @prudhvigodithi can confirm but it can be removed later is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gaiksaya you are right it should be starting from 2.x.
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit 389b816)
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit 389b816)
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit 389b816)
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit 389b816)
Description
Describe what this change achieves.
Issues Resolved
#239
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.