Adding windows and mac CI to 1.3 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.3 #745 +/- ##
============================================
- Coverage 77.66% 75.65% -2.01%
+ Complexity 4110 4005 -105
============================================
Files 296 296
Lines 17673 17661 -12
Branches 1882 1876 -6
============================================
- Hits 13725 13362 -363
- Misses 3041 3382 +341
- Partials 907 917 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
ohltyler
reviewed
Dec 5, 2022
| strategy: | ||
| matrix: | ||
| java: [8, 11, 14] | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
Should we run on macos-latest as well?
There was a problem hiding this comment.
Didn't originally add this as it wasn't part of what is needed for 1.3.7 and was worried about the deadline. However since window is passing, just add macos along with the needed test fix I made in the past on 2.x branch.
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
b4sjoo
previously approved these changes
Dec 5, 2022
ohltyler
reviewed
Dec 5, 2022
| os: [ubuntu-latest, macos-latest] | ||
| fail-fast: false | ||
|
|
||
| name: Build and Test Anomaly detection Plugin on multipule platforms |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
b4sjoo
approved these changes
Dec 5, 2022
ohltyler
approved these changes
Dec 6, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding windows CI to 1.3, split up workflows to regular build, bwc and docker security workflow.
Bumped jackson to 2.14.1 to match with core.
Didn't add multi node integration testing for windows CI as there are still some issues with deleting previous cluster logs, manually tested multi node windows works with AD. Issue for multi node set up for windows 1.3 (#747)
Issues Resolved
resolves #737
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.