[Backport to 1.2] fix missing dependency:commons-lang3 (#350)

[amitgalitz]

Description

Backporting PR that added the commons-lang3. This was added in order to fix a missing dependency issue that appeared in 1.3.0. This same issue is now appearing in 1.2.4 opensearch build process.

Issues Resolved

#359

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ylwu-amzn]

This same issue is now appearing in 1.2.4 opensearch build process.

Can you confirm if the missing dependency issue happens on 1.2.4 branch?
1.2.4 can build successfully locally for me and I see the latest commit passed CI workflow https://github.com/opensearch-project/anomaly-detection/runs/4800168307?check_suite_focus=true

[ylwu-amzn]

Checked job-scheduler 1.2 branch, they have upgraded com.cronutils:cron-utils to 9.1.6 opensearch-project/job-scheduler#118

But the job-scheduler-spi 1.2.4 maven snapshot not built from latest code. So I can build locally and the github CI workflow can pass. @peternied can you help rebuild job-scheduler-spi 1.2.4 snapshot and upload to maven?

[ylwu-amzn]

LGTM. Make sure CI can pass after infra team upload latest job-scheduler-spi 1.2.4 snapshot to maven.

[dblock]

LGTM. Make sure CI can pass after infra team upload latest job-scheduler-spi 1.2.4 snapshot to maven.

There's a chicken and egg problem where the distribution can't build without AD, so it won't upload the job-scheduler snapshot to maven. I PRed opensearch-project/opensearch-build#1462, see opensearch-project/opensearch-build#1463 for a description of the bug.

[dblock]

@amitgalitz You'll need to fix DCO, please -s.

[amitgalitz]

@amitgalitz You'll need to fix DCO, please -s.

I did signoff it off with that flag. Since its a backport PR its failing on Yaliangs signature. The failures is because Yaliang's email is set to private so the signature and the email github is accepting doesn't match. It seems like the way to fix it is to make the email public.I tried recommiting it after running this command (git commit --amend --signoff) and it didn't help. DCO passes now.

[ohltyler]

Btw, if you run into future problems, you can try something like git rebase --signoff HEAD~2, which should add the "Signed off by <>" message to the last 2 commits, for example

[peternied]

The 1.2.4 snapshot build completed - I've retriggered the Build and Test CI check

[amitgalitz]

The 1.2.4 snapshot build completed - I've retriggered the Build and Test CI check

Thank you Peter!

[ylwu-amzn]

Thanks @dblock , I thought we have separate workflow or manual way to build job-scheduler-spi snapshot and upload to maven. Bind all plugins together in workflow will make things complicated. We need 2 PRs to break the circular dependency.