Bumping anomaly-detection to 1.1.0.0 to use OpenSearch (main) 1.1.0 #175
Conversation
VachaShah
force-pushed
the
bump-to-1.1.0
branch
2 times, most recently
from
d787d51 to
3817101
Compare
.github/workflows/CI.yml
Outdated
| ref: 'main' | ||
| - name: Build OpenSearch | ||
| working-directory: ./OpenSearch | ||
| run: ./gradlew publishToMavenLocal -Dbuild.snapshot=false |
There was a problem hiding this comment.
We are consuming OpenSearch 1.1.0-SNAPSHOT but publishing OpenSearch 1.1.0 to maven.
Can you move it to publish the snapshot, this would unblock the builds in CI.
| run: ./gradlew publishToMavenLocal -Dbuild.snapshot=false | |
| run: ./gradlew publishToMavenLocal |
There was a problem hiding this comment.
Missed this, I have updated it. Thank you :)
Signed-off-by: Vacha <vachshah@amazon.com>
VachaShah
force-pushed
the
bump-to-1.1.0
branch
from
3817101 to
8326184
Compare
| "${baseName}" { | ||
| testDistribution = "ARCHIVE" | ||
| versions = ["7.10.2","1.0.0"] | ||
| versions = ["7.10.2","1.1.0-SNAPSHOT"] |
There was a problem hiding this comment.
Should we also test upgrade with last version OS 1.0?
BTW, the CI workflow failed as "Could not find org.opensearch.gradle:build-tools:1.1.0."
There was a problem hiding this comment.
Hi @ylwu-amzn, the corresponding bwc tests are added so that the core framework for bwc for plugins is ready to use and they are an example of how the bwc tests can be added in the plugins. Each plugin owners can now take up the tests and enhance them to include multiple versions and test required functionalities.
For the CI failure, I am working on fixing that since AD is consuming the snapshot build while job-scheduler and common-utils are not, I am making corresponding changes in the respective repos.
…uild Signed-off-by: Vacha <vachshah@amazon.com>
VachaShah
force-pushed
the
bump-to-1.1.0
branch
from
6666dfb to
e977396
Compare
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
============================================
+ Coverage 67.64% 67.69% +0.05%
- Complexity 2885 2887 +2
============================================
Files 270 270
Lines 14104 14104
Branches 1418 1418
============================================
+ Hits 9540 9548 +8
+ Misses 3971 3967 -4
+ Partials 593 589 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This plus #176 is probably what we want to default the build to produce a snapshot version. |
|
Anomaly-detection main branch is now 1.1 and we're not working on 2.0. I think this means it should depend on OpenSearch 1.x branch (right now OpenSearch/main is 2.0)? |
|
I'll merge this to get unblocked for #176. |
ohltyler
added
the
infra
7 participants
Signed-off-by: Vacha vachshah@amazon.com
Description
Bumping up
anomaly-detectionto build with OpenSearch main which is 1.1.0 and use 1.1.0.0 forjob-schedulerandcommon-utils.As with the branching and release strategy for the project opensearch-project/.github#13
Here is how it should look like:
Plugin/library main builds out of OpenSearch main.
Plugin/library 1.x builds out of OpenSearch 1.x.
Plugin/library 1.0 builds out of OpenSearch 1.0.
This allows us to fail fast and get ready for release.
As part of adding backwards compatibility test framework, we are developing tests as an example in Anomaly Detection which needs the bwc framework from OpenSearch main.
Ref: opensearch-project/OpenSearch#1002
Meta issue: opensearch-project/opensearch-build#90
Issues Resolved
#156
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.