Fix flaky ITs #1571
Merged
Fix flaky ITs #1571
+65
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
VijayanB,
amitgalitz,
dbwiddis,
jackiehanyang,
jmazanec15,
jngz-es,
joshpalis,
ohltyler,
owaiskazi19,
saratvemulapalli,
sean-zheng-amazon,
vamshin and
ylwu-amzn
as code owners
sharing - RealTimeFrequencySmokeIT: capture baseline ad_execute_request_count and use assertBusy to wait for a delta ≥ 2 via _local/stats; aggregate counts across nodes to tolerate parallel ITs on a shared cluster (ran via ./gradlew ':integTestRemote'). Added getLocalAdExecuteRequestCount helper and logging to aid diagnosis. - AnomalyDetectorRestApiIT: when resource sharing is enabled, allow _version ≥ previous+1 since Security’s ResourceSharingIndexHandler triggers an extra update to set all_shared_principals. These changes reduce IT flakiness without altering production behavior. Signed-off-by: kaituo <kaituo@amazon.com>
66 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
============================================
- Coverage 81.44% 81.42% -0.03%
- Complexity 6137 6140 +3
============================================
Files 542 542
Lines 24898 24898
Branches 2540 2540
============================================
- Hits 20279 20273 -6
- Misses 3352 3365 +13
+ Partials 1267 1260 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Security CI will be fixed by #1572 |
jackiehanyang
approved these changes
Oct 2, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
…ce (#1571) sharing - RealTimeFrequencySmokeIT: capture baseline ad_execute_request_count and use assertBusy to wait for a delta ≥ 2 via _local/stats; aggregate counts across nodes to tolerate parallel ITs on a shared cluster (ran via ./gradlew ':integTestRemote'). Added getLocalAdExecuteRequestCount helper and logging to aid diagnosis. - AnomalyDetectorRestApiIT: when resource sharing is enabled, allow _version ≥ previous+1 since Security’s ResourceSharingIndexHandler triggers an extra update to set all_shared_principals. These changes reduce IT flakiness without altering production behavior. Signed-off-by: kaituo <kaituo@amazon.com> (cherry picked from commit 3c66c83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Oct 2, 2025
…ce (#1571) (#1574) sharing - RealTimeFrequencySmokeIT: capture baseline ad_execute_request_count and use assertBusy to wait for a delta ≥ 2 via _local/stats; aggregate counts across nodes to tolerate parallel ITs on a shared cluster (ran via ./gradlew ':integTestRemote'). Added getLocalAdExecuteRequestCount helper and logging to aid diagnosis. - AnomalyDetectorRestApiIT: when resource sharing is enabled, allow _version ≥ previous+1 since Security’s ResourceSharingIndexHandler triggers an extra update to set all_shared_principals. These changes reduce IT flakiness without altering production behavior. (cherry picked from commit 3c66c83) Signed-off-by: kaituo <kaituo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
These changes reduce IT flakiness without altering production behavior.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
opensearch-project/opensearch-build#5693
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.