[Backport 3.1] fix: advance past current interval & anchor on now #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem -------- * `nextNiceInterval()` used a “≥” check, so when the next “nice” value equalled `currentMin` it returned the **same** interval. The interval‑explorer treats an unchanged return as a terminal condition, so exploration stopped and `suggestForecast` failed on sample‑log data. * Interval calculation anchored on the first **future** timestamp if one existed, whereas run‑once / real‑time forecasting anchors on the current time—causing the two paths to disagree on data sufficiency. Fix --- * Change comparison in `nextNiceInterval()` from `>=` to `>` so it always returns the next larger interval, letting the explorer continue. * Anchor interval calculation on the current time (`now`) instead of any future date, making all forecast modes consistent. Tests ----- * Added IT Signed-off-by: Kaituo Li <kaituo@amazon.com> (cherry picked from commit 03b261a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
VijayanB,
amitgalitz,
dbwiddis,
jackiehanyang,
jmazanec15,
jngz-es,
joshpalis,
kaituo,
ohltyler,
owaiskazi19,
saratvemulapalli,
sean-zheng-amazon,
vamshin and
ylwu-amzn
as code owners
amitgalitz
approved these changes
Jul 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.1 #1529 +/- ##
============================================
+ Coverage 81.60% 81.72% +0.11%
- Complexity 6026 6047 +21
============================================
Files 536 536
Lines 24381 24401 +20
Branches 2490 2493 +3
============================================
+ Hits 19897 19941 +44
+ Misses 3246 3230 -16
+ Partials 1238 1230 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 03b261a from #1528.