Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 3dd042e from #1502.

Mark FORECAST_FAILURE as a non-ending state so TaskManager recognizes the task as stoppable. Previously, TaskManager.stopLatestRealtimeTask failed to stop the task, as `isDone()` returned false for FORECAST_FAILURE, causing a "job is already stopped" error.

Testing:
- Manually verified forecaster can now be stopped successfully from FORECAST_FAILURE state.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 3dd042e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (1e84491) to head (b752379).
Report is 1 commits behind head on 3.1.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.1    #1503      +/-   ##
============================================
+ Coverage     81.41%   81.43%   +0.02%     
- Complexity     5975     5977       +2     
============================================
  Files           536      536              
  Lines         24214    24215       +1     
  Branches       2446     2446              
============================================
+ Hits          19713    19720       +7     
+ Misses         3293     3289       -4     
+ Partials       1208     1206       -2     
Flag Coverage Δ
plugin 81.43% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ava/org/opensearch/timeseries/model/TaskState.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaituo kaituo merged commit 88c6541 into 3.1 Jun 23, 2025
26 of 42 checks passed
@gaiksaya gaiksaya deleted the backport/backport-1502-to-3.1 branch October 27, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants