Skip to content

Fix stopping issue when forecaster is in FORECAST_FAILURE state #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix stopping issue when forecaster is in FORECAST_FAILURE state #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release-notes/opensearch-anomaly-detection.release-notes-3.1.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ Compatible with OpenSearch 3.1.0
- Fix incorrect task state handling in ForecastRunOnceTransportAction ([#1489](https://github.com/opensearch-project/anomaly-detection/pull/1489))
- Fix incorrect task state handling in ForecastRunOnceTransportAction ([#1493](https://github.com/opensearch-project/anomaly-detection/pull/1493))
- Refine cold-start, window delay, and task updates ([#1496](https://github.com/opensearch-project/anomaly-detection/pull/1496))
- Fix stopping issue when forecaster is in FORECAST_FAILURE state ([#1502](https://github.com/opensearch-project/anomaly-detection/pull/1502))

3 changes: 2 additions & 1 deletion src/main/java/org/opensearch/timeseries/model/TaskState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ public String getDescription() {
TaskState.RUNNING.name(),
INIT_TEST.name(),
AWAITING_DATA_TO_INIT.name(),
AWAITING_DATA_TO_RESTART.name()
AWAITING_DATA_TO_RESTART.name(),
FORECAST_FAILURE.name()
);

public static boolean isAwaitState(String state) {
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/opensearch/timeseries/model/TaskStateTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,14 @@ public void testNotEndedStatesConstant() {
List<String> list = TaskState.NOT_ENDED_STATES;

// expected size and membership
assertEquals(6, list.size());
assertEquals(7, list.size());
assertTrue(list.contains(TaskState.CREATED.name()));
assertTrue(list.contains(TaskState.INIT.name()));
assertTrue(list.contains(TaskState.RUNNING.name()));
assertTrue(list.contains(TaskState.INIT_TEST.name()));
assertTrue(list.contains(TaskState.AWAITING_DATA_TO_INIT.name()));
assertTrue(list.contains(TaskState.AWAITING_DATA_TO_RESTART.name()));
assertTrue(list.contains(TaskState.FORECAST_FAILURE.name()));

// an obviously ended state must be absent
assertFalse(list.contains(TaskState.FINISHED.name()));
Expand Down
Loading