Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 08dceb4 from #1496.

- Skip checkpoint writes during historical/run once
- Add retryOnConflict to task updates to dodge version clashes
- Switch window-delay calculation from 20 % padding (gap × 1.2) to a bucket-based approach. Motivation: the multiplicative cushion scaled with absolute lag, so a multi-hour ingest gap could inflate the delay into days, causing cold start failures.  Tying the delay to config intervals (plus one safety bucket) keeps it proportional and restores prompt results.

Testing done:
* added IT: https://tinyurl.com/5n98z3ue

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 08dceb4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kaituo kaituo merged commit 1e84491 into 3.1 Jun 19, 2025
22 of 40 checks passed
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (ed4658d) to head (936df0d).
Report is 1 commits behind head on 3.1.

Files with missing lines Patch % Lines
...ansport/BaseSuggestConfigParamTransportAction.java 0.00% 5 Missing ⚠️
.../opensearch/forecast/ml/ForecastCheckpointDao.java 0.00% 2 Missing ⚠️
...a/org/opensearch/timeseries/ml/ModelColdStart.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.1    #1497   +/-   ##
=========================================
  Coverage     81.40%   81.41%           
- Complexity     5972     5976    +4     
=========================================
  Files           536      536           
  Lines         24205    24214    +9     
  Branches       2443     2446    +3     
=========================================
+ Hits          19705    19714    +9     
- Misses         3291     3293    +2     
+ Partials       1209     1207    -2     
Flag Coverage Δ
plugin 81.41% <30.76%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/main/java/org/opensearch/ad/ml/ADColdStart.java 80.85% <100.00%> (+0.20%) ⬆️
...va/org/opensearch/timeseries/task/TaskManager.java 80.69% <100.00%> (-0.58%) ⬇️
.../opensearch/forecast/ml/ForecastCheckpointDao.java 22.43% <0.00%> (-0.15%) ⬇️
...a/org/opensearch/timeseries/ml/ModelColdStart.java 78.32% <33.33%> (-0.78%) ⬇️
...ansport/BaseSuggestConfigParamTransportAction.java 51.48% <0.00%> (-2.13%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gaiksaya gaiksaya deleted the backport/backport-1496-to-3.1 branch October 27, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants