-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #1251
Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #1251
Conversation
…IndexDescriptors Signed-off-by: Craig Perkins <cwperx@amazon.com>
src/main/java/org/opensearch/timeseries/TimeSeriesAnalyticsPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/constant/CommonName.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/TimeSeriesAnalyticsPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/TimeSeriesAnalyticsPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/timeseries/TimeSeriesAnalyticsPlugin.java
Outdated
Show resolved
Hide resolved
When adding an system index, do we still need to put the name or pattern in https://github.com/opensearch-project/security/blob/37afcaab74c8ef3133249f8ebe728ea897d0af2f/src/main/java/org/opensearch/security/tools/democonfig/SecuritySettingsConfigurer.java#L64-L67 ? |
You should add the name of the index if you create a single index and you should use a pattern if you create multiple system indices based on a pattern. If you create |
I meant to ask do we still need to put system index name/patterns in src/main/java/org/opensearch/security/tools/democonfig/SecuritySettingsConfigurer.java? Is putting system index name/patterns in each plugin's files (e.g., AD's TimeSeriesAnalyticsPlugin.java) enough? Or we need to put in both places? |
This PR is a step towards eliminating the need to make a PR to the security repo to add it to the list in |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
============================================
- Coverage 71.83% 71.65% -0.18%
+ Complexity 4898 4881 -17
============================================
Files 518 518
Lines 22879 22884 +5
Branches 2245 2245
============================================
- Hits 16434 16398 -36
- Misses 5410 5444 +34
- Partials 1035 1042 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks Do we need to backport the PR to 2.x? |
Yes please |
…IndexDescriptors (#1251) * Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors Signed-off-by: Craig Perkins <cwperx@amazon.com> * Respond to code review feedback Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove newline Signed-off-by: Craig Perkins <cwperx@amazon.com> * Bump bwc version Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit c059eff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…IndexDescriptors (#1251) (#1254) * Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors * Respond to code review feedback * Remove newline * Bump bwc version --------- (cherry picked from commit c059eff) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR registers the system indices in this plugin through the SystemIndexPlugin extension point in core. These indices will not be functionally different than they are today, its just a formal registration as a system index.
Issues Resolved
Related to opensearch-project/security#4439
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.