Disable ktlint for alerting as it has errors on Windows #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
1 task
sbcd90
approved these changes
Sep 27, 2022
lezzago
approved these changes
Sep 27, 2022
|
Note that this issue is resolved on ktlint 0.47.0 but shows a lot of linting errors therefore the temp solution is just to disable ktlint. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 3a844f8)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 3a844f8)
peterzhuamazon
added a commit
that referenced
this pull request
Sep 27, 2022
peterzhuamazon
added a commit
that referenced
this pull request
Sep 27, 2022
peterzhuamazon
added a commit
to peterzhuamazon/alerting
that referenced
this pull request
Sep 27, 2022
…roject#570) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
toepkerd-zz
pushed a commit
to toepkerd-zz/alerting
that referenced
this pull request
Sep 28, 2022
…roject#570) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
|
We should have done #214 instead of just disabling this. |
eirsep
added a commit
that referenced
this pull request
Oct 10, 2022
* Added 2.1 release notes. (#485) (#487) * Added 2.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 9f3c393) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> * Staging for version increment automation (#489) (#503) * Version increment automation Signed-off-by: pgodithi <pgodithi@amazon.com> * Version increment automation: task rename updateVersion Signed-off-by: pgodithi <pgodithi@amazon.com> (cherry picked from commit 3b8bfe7) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> * Add support for reproducible builds (#472) (#499) As per gradle [docs] add support to remove timestamps and package with same order which is required from [reproducible] builds [docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives [reproducible]: https://reproducible-builds.org/ Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org> (cherry picked from commit a27d5a2) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com> * Refactored backwards compatibility tests to point to the OpenSearch 1.1.0.0 zip following deprecation of ODFE. (#510) (#512) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit fea6b4a) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> * Bumping 2.x branch version from 2.1.0 to 2.2.0. Bumped mockito-core version from 4.3.1 to 4.6.1. (#506) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.2 release notes. (#514) * Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.2 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped 2.x branch from version 2.2.0 to 2.3.0. (#547) * Bumped 2.x branch from version 2.2.0 to 2.3.0. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped mockito core version. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Deprecate the Master nomenclature (#548) (#549) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Added 2.3 release notes. (#551) * Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * moving over data models from alerting to common-utils (#556) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * backport monitor datasources to 2.x (#558) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * expose delete monitor api from alerting (#568) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Use findings and alerts models, dtos from common utils (#569) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Disable ktlint for alerting as it has errors on Windows (#570) (#571) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 3a844f8) Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> * Recreate request object from writeable for Get alerts and get findings (#577) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Use alerting models and dtos from common-utils dependencies Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * port over datasources alert index usage correctly Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Issue #, if available:
#557
Description of changes:
Disable ktlint for alerting as it has errors on Windows
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.