PPL Alerting: Get Alerts and Alert Lifecycle #1972
Open
+1,749
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
toepkerd
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
eirsep
reviewed
Nov 3, 2025
| val monitorV2Id: String? | ||
| val monitorV2Ids: List<String>? | ||
| val alertV2Ids: List<String>? | ||
| val boolQueryBuilder: BoolQueryBuilder? |
There was a problem hiding this comment.
do we intend to support BoolQueryBuilder in API? user prolly wouldn't know Alert structure and this could be a security issue i reckon if user is able to query alerts by User fields,
eirsep
reviewed
Nov 3, 2025
| import org.opensearch.index.query.BoolQueryBuilder | ||
| import java.io.IOException | ||
|
|
||
| class GetAlertsV2Request : ActionRequest { |
There was a problem hiding this comment.
shouldn't we also be implement xcontent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get Alerts and Alert Lifecycle
ITs depend on execute monitor functionality that has not yet been published, but they have been written: https://github.com/toepkerd/alerting/blob/ppl-main/alerting/src/test/kotlin/org/opensearch/alerting/alertsv2/AlertV2IndicesIT.kt
Related Issues
#1880
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.