bug/alerting-action-preview #337
Conversation
Signed-off-by: David Sinclair <dsincla@rei.com>
Signed-off-by: David Sinclair <dsincla@rei.com>
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 52.73% 52.67% -0.07%
==========================================
Files 209 207 -2
Lines 5450 5443 -7
Branches 763 763
==========================================
- Hits 2874 2867 -7
Misses 2574 2574
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
resolves #332 |
| } = this.props; | ||
| switch (searchType) { | ||
| case SEARCH_TYPE.CLUSTER_METRICS: | ||
| if (canExecuteClusterMetricsMonitor(uri)) this.onRunExecute(); | ||
| break; | ||
| default: | ||
| onRun(); |
There was a problem hiding this comment.
Looking at this method inside the ConfigureTriggers, it seems to be calling the same endpoint with the same monitor data it receives as prop which is passed to this component. Can you explain a little more, why we need this call?
|
The cypress tests are failing because the alerting plugin is currently set to version 2.4, whereas OpenSearch-Dashboards branch used by the workflow is set to 2.4.1. Once this PR #363 is merged, and you've rebased your dev branch, the cypress check should succeed. |
| @@ -131,7 +131,7 @@ class ConfigureTriggers extends React.Component { | |||
| case SEARCH_TYPE.QUERY: | |||
| case SEARCH_TYPE.GRAPH: | |||
| const searchRequest = buildRequest(formikValues); | |||
| _.set(monitorToExecute, 'inputs[0].search', searchRequest); | |||
| _.set(monitorToExecute, 'inputs[0]', searchRequest); | |||
There was a problem hiding this comment.
Just FYI, This is already checked in as part of another PR
|
The original issue seems to be fixed by #334 -- closing this. |
Signed-off-by: David Sinclair dsincla@rei.com
Description
public/pages/CreateMonitor/containers/DefineMonitor/DefineMonitor.jscomponentDidMountof DefineTrigger, also run theonRunmethod to get thecontextsaved from the upperConfigureActionscomponent, which is the samecontextused to display preview messages.Issues Resolved
This will hopefully resolve #152 -- note, the correct use of Mustache template for the issue in the ticket would be like this:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.