Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add support to restrict creation & deletion if system repository and mutation of immutable settings of system repository #9839

Merged
merged 14 commits into from
Oct 4, 2023
Merged

[Remote Store] Add support to restrict creation & deletion if system repository and mutation of immutable settings of system repository #9839

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d167e34
[Remote Store] Introducing concept of RestrictedSystemRepositorySetti…
psychbot Sep 6, 2023
3163b8a
Updating ChangeLog
psychbot Sep 6, 2023
311836e
Fixing node join flow with repository metadata updated after node joi…
psychbot Sep 7, 2023
4dc627b
Fixing tests and updating code
psychbot Sep 11, 2023
e91cdb3
Fixing TestCluster repository clean up logic
psychbot Sep 12, 2023
73e78ec
Fixing using newRepositoryMetadata instead of currentRepositoryMetada…
psychbot Sep 14, 2023
6238847
Removing repo consitency check for remote store it as we cant delete …
psychbot Sep 18, 2023
d2fe439
Adding Integ Tests
psychbot Sep 19, 2023
8c94edf
Fixing one integ test and removing unnecessary cleanup code
psychbot Sep 20, 2023
42ef348
Changes to not surface out system_repository in rest get repositories…
psychbot Sep 28, 2023
9e4908f
Improving codecov
psychbot Sep 29, 2023
4af05ea
Fixing test
psychbot Sep 29, 2023
772ddd2
Updating message
psychbot Sep 29, 2023
402da4c
Update CHANGELOG.md
psychbot Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing test 
Signed-off-by: Dharmesh 💤 <sdharms@amazon.com>
  • Loading branch information
@psychbot
psychbot committed Oct 4, 2023
commit 4af05ea192cf36115dfd476aa145c4ae8533ce93
2 changes: 1 addition & 1 deletion plugins/repository-s3/src/test/java/org/opensearch/repositories/s3/S3RepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public void testRestrictedSettingsDefault() {
final RepositoryMetadata metadata = new RepositoryMetadata("dummy-repo", "mock", Settings.EMPTY);
try (S3Repository s3repo = createS3Repo(metadata)) {
List<Setting<?>> restrictedSettings = s3repo.getRestrictedSystemRepositorySettings();
assertThat(restrictedSettings.size(), is(4));
assertThat(restrictedSettings.size(), is(5));
assertTrue(restrictedSettings.contains(BlobStoreRepository.SYSTEM_REPOSITORY_SETTING));
assertTrue(restrictedSettings.contains(BlobStoreRepository.READONLY_SETTING));
assertTrue(restrictedSettings.contains(BlobStoreRepository.REMOTE_STORE_INDEX_SHALLOW_COPY));
Expand Down