Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry-Otel] Added support for OtlpGrpcSpanExporter exporter #9666

Merged
merged 18 commits into from
Sep 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modified endpoint comment
Signed-off-by: Shephali Mittal <shephalm@amazon.com>
  • Loading branch information
Shephali Mittal committed Sep 5, 2023
commit 21dfd48bf85039ed58793c92bf8567bd9ed7eb07
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private OtlpGrpcSpanExporterProvider(OtlpGrpcSpanExporter exporter) {
public static OtlpGrpcSpanExporterProvider create(Settings settings) {
OtlpGrpcSpanExporter exporter;
String endpoint = OTelTelemetrySettings.TRACER_SPAN_EXPORTER_ENDPOINT.get(settings);
// if endpoint is empty, do not set Endpoint
// if endpoint is empty, do not set Endpoint. The default endpoint is "http://localhost:4317"
if (endpoint.isEmpty()) {
exporter = OtlpGrpcSpanExporter.builder().build();
Shephalimittal marked this conversation as resolved.
Show resolved Hide resolved
} else {
Expand Down