Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum version check on SearchExtBuilder support in Searc… #9641

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

austintlee
Copy link
Contributor

…hResponse (Issue # 9328)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [x ] Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hResponse (Issue # 9328)

Signed-off-by: Austin Lee <austin@aryn.ai>
@austintlee
Copy link
Contributor Author

Does this need an entry in the changelog??

@reta
Copy link
Collaborator

reta commented Aug 30, 2023

Does this need an entry in the changelog??

Nope, taking care of that

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change a71a93e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshCommit
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #9641 (a71a93e) into main (60787b8) will decrease coverage by 0.43%.
Report is 4 commits behind head on main.
The diff coverage is 82.14%.

@@             Coverage Diff              @@
##               main    #9641      +/-   ##
============================================
- Coverage     71.53%   71.11%   -0.43%     
+ Complexity    57897    57575     -322     
============================================
  Files          4782     4782              
  Lines        271332   271331       -1     
  Branches      39614    39616       +2     
============================================
- Hits         194107   192946    -1161     
- Misses        61255    62186     +931     
- Partials      15970    16199     +229     
Files Changed Coverage Δ
...ain/java/org/opensearch/common/unit/TimeValue.java 86.25% <ø> (-1.25%) ⬇️
...ibs/core/src/main/java/org/opensearch/Version.java 77.77% <ø> (ø)
.../src/main/java/org/opensearch/core/ParseField.java 95.74% <ø> (ø)
...ava/org/opensearch/core/action/ActionListener.java 81.30% <0.00%> (-1.87%) ⬇️
...g/opensearch/core/common/bytes/BytesReference.java 74.28% <ø> (ø)
.../core/common/io/stream/NamedWriteableRegistry.java 100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 88.86% <ø> (-0.59%) ⬇️
...opensearch/core/common/io/stream/StreamOutput.java 94.88% <ø> (-0.97%) ⬇️
.../opensearch/core/common/settings/SecureString.java 78.78% <ø> (ø)
...org/opensearch/core/common/unit/ByteSizeValue.java 99.08% <ø> (ø)
... and 42 more

... and 447 files with indirect coverage changes

@reta reta merged commit bb38ed4 into opensearch-project:main Aug 30, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…hResponse (Issue # 9328) (opensearch-project#9641)

Signed-off-by: Austin Lee <austin@aryn.ai>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…hResponse (Issue # 9328) (opensearch-project#9641)

Signed-off-by: Austin Lee <austin@aryn.ai>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…hResponse (Issue # 9328) (opensearch-project#9641)

Signed-off-by: Austin Lee <austin@aryn.ai>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants