Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing docs-beta links with /docs #957

Merged

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

The link checker is failing with the docs-beta links for example in PR #947. Updating the docs-beta link references to the /docs links.

Issues Resolved

#956

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e6ecba9

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e6ecba9

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e6ecba9

@VachaShah VachaShah requested a review from adnapibar July 13, 2021 00:26
@saratvemulapalli
Copy link
Member

start gradle start

@CEHENKLE
Copy link
Member

start gradle check

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that linkchecker caught this! We were going to have to hunt down all the places where we link to docs-beta ...

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e6ecba9
Log 329

Reports 329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants