Fix flaky test ArchivedIndexSettingsIT

[ankitkala]

Description

For simulating an archived index setting, we create a dummy plugin with a setting and configure the setting value while creating the index. Then we add new nodes to the cluster without dummy plugin and kill the old nodes. Saw this issue transiently after the nodes restart. Adding an assertBusy to handle the transient issue.

"org.opensearch.indices.settings.ArchivedIndexSettingsIT.testArchiveSettings" -Dtests.seed=E9536E5760BDE887 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=de-LU -Dtests.timezone=Asia/Yerevan -Druntime.java=17

org.opensearch.indices.settings.ArchivedIndexSettingsIT > testArchiveSettings FAILED
    [test] IndexNotFoundException[no such index [test]]
        at __randomizedtesting.SeedInfo.seed([E9536E5760BDE887:4EB4845B78280B16]:0)
        at app//org.opensearch.cluster.metadata.IndexNameExpressionResolver$WildcardExpressionResolver.indexNotFoundException(IndexNameExpressionResolver.java:1062)
        at 
.
.
.
.
app//org.opensearch.indices.settings.ArchivedIndexSettingsIT.testArchiveSettings(ArchivedIndexSettingsIT.java:52)

Related Issues

#9497

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23319/
• CommitID: 43f1bb5

[codecov]

Codecov Report

Merging #9515 (2ce158c) into main (f5a6e6d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9515      +/-   ##
============================================
- Coverage     71.05%   71.03%   -0.02%     
- Complexity    57404    57425      +21     
============================================
  Files          4778     4778              
  Lines        270897   270897              
  Branches      39584    39584              
============================================
- Hits         192476   192433      -43     
- Misses        62231    62318      +87     
+ Partials      16190    16146      -44     

see 469 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23368/
• CommitID: 2ce158c

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/23459/
• CommitID: f23a98e
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/23464/
• CommitID: bb0ab30
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/23471/
• CommitID: 0936c03
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ankitkala]

Flaky mixedClusterTest: #9547