Add Crypto Provider interface to provide encryption and decryption capabilities #9505
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Addressed review comments Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Made FrameCryptoProvider a CryptoProvider type to allow registering other crypto provider types Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Moved crypto cache and crypto manager code to libs/encryption-sdk Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> raw type warning fix Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Added changelog entries Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Fixed rawtype warnings Signed-off-by: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Removing Frame based Crypto provider and adding Dummy Crypto provider Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
force-pushed
the
crypto-core-lib
branch
from
5e5ba00
to
faa1807
Compare
Compatibility status:Checks if related components are compatible with change 5d3633c Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9505 +/- ##
============================================
- Coverage 71.20% 71.13% -0.08%
+ Complexity 57474 57443 -31
============================================
Files 4776 4783 +7
Lines 270815 270974 +159
Branches 39584 39586 +2
============================================
- Hits 192835 192757 -78
- Misses 61741 61974 +233
- Partials 16239 16243 +4
|
gbbafna
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
| assertNotNull(cryptoManager); | ||
| } | ||
|
|
||
| // public void testUnsupportedAlgorithm() { |
There was a problem hiding this comment.
do we need to fix this? or remove?
There was a problem hiding this comment.
i can remove this for now in my next commit.
|
|
||
| import com.amazonaws.encryptionsdk.caching.CachingCryptoMaterialsManager; | ||
|
|
||
| public class DummyCryptoProvider implements CryptoProvider { |
There was a problem hiding this comment.
Why do we need this in libs?
There was a problem hiding this comment.
CryptoManager needs 1 implementation of CryptoProvider to unblock itself. This is only a temporary provider for now . Once we have a RealCryptoProvider we can remove it . I will add a ToDo for this .
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Description
Adding
encryption-sdkin OpenSearch which provides interfaces for encryption and decryption capabilities.Related Issues
Partially resolves #7229
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.