-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Secure Bwc documentation to TESTING.md #9414
Add Secure Bwc documentation to TESTING.md #9414
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9414 +/- ##
============================================
+ Coverage 71.08% 71.16% +0.07%
- Complexity 57428 57534 +106
============================================
Files 4781 4781
Lines 271184 271184
Branches 39591 39591
============================================
+ Hits 192780 192994 +214
+ Misses 62122 61934 -188
+ Partials 16282 16256 -26 |
@dblock here is the documentation you requested. Failures are unrelated. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm curious if we could improve this to be copy-pasteable by setting an environemnt variable for <TARGET_VERSION>
and using it.
Hi @dbwiddis, that is a good idea. I am not sure how we would want to go about referencing the target version to convert from however. We could always assume that the current version is the "new" version, but I don't know what we would want to do for the version we are converting from. |
Compatibility again. Restarting :) |
Compatibility status:Checks if related components are compatible with change 6a5b464 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some nits. TOC is a must have, SORRY
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 4f197b6 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Flaky tests:
|
* Update BWC testing documentation Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add placeholder Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix typos Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix table of contents order Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add colon Signed-off-by: Stephen Crawford <steecraw@amazon.com> * trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* Update BWC testing documentation Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add placeholder Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix typos Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix table of contents order Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add colon Signed-off-by: Stephen Crawford <steecraw@amazon.com> * trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
* Update BWC testing documentation Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix code block Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add placeholder Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix typos Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix table of contents order Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Add colon Signed-off-by: Stephen Crawford <steecraw@amazon.com> * trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Add Secure BWC documentation to TESTING.md as a followup to #8900.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
New functionality includes testing.All tests passNew functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.