Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Refresh OpenSearch nodes version in cluster state after upgrade (#865) #926

Merged
merged 1 commit into from
Jul 2, 2021
Merged

[1.x] Refresh OpenSearch nodes version in cluster state after upgrade (#865) #926

merged 1 commit into from
Jul 2, 2021

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Jul 2, 2021 •
edited
Loading

Description

Backport PR #865 to 1.x branch.

Fix:

  • As soon as OpenSearch node becomes master, it refreshes the nodes version in cluster state by comparing against their channel version. Right now, it doesn't wait for all Elasticsearch nodes to leave the cluster before refreshing the version.
  • There was bug in DiscoveryNode BWC serialization logic where any ES version < 7.10.2 was getting over-written with 7.10.2

Issues Resolved

#827

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shwetathareja
Refresh OpenSearch nodes version in cluster state after upgrade (open…
d58baa4 
…search-project#865)

Signed-off-by: Shweta Thareja <tharejas@amazon.com>

Co-authored-by: Shweta Thareja <tharejas@amazon.com>
@tlfeng tlfeng requested review from adnapibar and shwetathareja July 2, 2021 16:19
@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments bug Something isn't working v1.0.0 Version 1.0.0 rolling-upgrade Issues related to rolling upgrades labels Jul 2, 2021
@tlfeng tlfeng requested a review from abbashus July 2, 2021 16:22
@adnapibar
Copy link
Contributor

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d58baa4

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d58baa4

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success d58baa4

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d58baa4
Log 300

Reports 300

@adnapibar adnapibar merged commit b383355 into opensearch-project:1.x Jul 2, 2021
adnapibar pushed a commit that referenced this pull request Jul 2, 2021
@shwetathareja
Refresh OpenSearch nodes version in cluster state after upgrade (#865) (
6a5f9b0 
#926)

Signed-off-by: Shweta Thareja <tharejas@amazon.com>
Co-authored-by: shwetathareja <shwetathareja@live.com>
@tlfeng tlfeng deleted the 1.x-refresh-version branch September 20, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@abbashus abbashus Awaiting requested review from abbashus

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments bug Something isn't working rolling-upgrade Issues related to rolling upgrades v1.0.0 Version 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlfeng @adnapibar @opensearch-ci-bot @shwetathareja