Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Add 'tagline' back to MainResponse in server that was removed in PR #427 #915

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Jul 1, 2021

Description

Backport #913 (main) #914 (1.x) to 1.0 branch.

After the change in the PR, the tagline field is back:

{
  "name" : "node-9200",
  "cluster_name" : "opensearch",
  "cluster_uuid" : "IoY5158sQp6oz5lkCPCVUg",
  "version" : {
    "distribution" : "opensearch",
    "number" : "1.1.0-SNAPSHOT",
    "build_type" : "tar",
    "build_hash" : "79e1180251d26fd98fa88e42d4c4eca1a6768b09",
    "build_date" : "2021-06-30T23:15:13.489461Z",
    "build_snapshot" : true,
    "lucene_version" : "8.8.2",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

Issues Resolved

#901

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng added the backport PRs or issues specific to backporting features or enhancments label Jul 1, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1

…pensearch-project#427 (opensearch-project#913)

* Add "tagline" field back to "MainResponse" in sever side (not in rest-high-level-client side) that removed in PR opensearch-project#427 .
* Replace with a new tagline "The OpenSearch Project: https://opensearch.org/".
* Turn the tagline into a constant in server/src/main/java/org/opensearch/action/main/MainResponse.java.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng force-pushed the 1.0-tagline-server branch from 85313af to 96e2cfa Compare July 1, 2021 22:36
@tlfeng tlfeng marked this pull request as ready for review July 1, 2021 22:37
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 96e2cfa

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 96e2cfa

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 96e2cfa

@adnapibar
Copy link
Contributor

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 96e2cfa
Log 295

Reports 295

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 2, 2021

The test failure in log 295:

> Task :plugins:repository-azure:internalClusterTest

REPRODUCE WITH: ./gradlew ':plugins:repository-azure:internalClusterTest' --tests "org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles" -Dtests.seed=7A97F545D07A8177 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=sq -Dtests.timezone=GB-Eire -Druntime.java=15

org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests > classMethod FAILED
    java.lang.Exception: Suite timeout exceeded (>= 1200000 msec).
        at __randomizedtesting.SeedInfo.seed([7A97F545D07A8177]:0)


Suite: Test class org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 2, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 96e2cfa
Log 296

Reports 296

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 2, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 96e2cfa
Log 297

Reports 297

@tlfeng
Copy link
Collaborator Author

tlfeng commented Jul 2, 2021

The test failure in log 295:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.GeoShapeIntegrationIT.testOrientationPersistence" -Dtests.seed=FF832DAFA222E38C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=es -Dtests.timezone=Asia/Atyrau -Druntime.java=15

org.opensearch.search.geo.GeoShapeIntegrationIT > testOrientationPersistence FAILED
    java.lang.AssertionError: timed out waiting for green state

The above test failures aren't reproducible in my local machine.

@tlfeng tlfeng merged commit 7251b2d into opensearch-project:1.0 Jul 2, 2021
@tlfeng tlfeng deleted the 1.0-tagline-server branch July 2, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backwards-compatibility v1.0.0 Version 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants