-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Add 'tagline' back to MainResponse in server that was removed in PR #427 #915
Conversation
✅ DCO Check Passed 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1 |
✅ Gradle Wrapper Validation success 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1 |
✅ Gradle Precommit success 85313affc9d2eb42a25dcfb4d38732b3ea8d0dc1 |
…pensearch-project#427 (opensearch-project#913) * Add "tagline" field back to "MainResponse" in sever side (not in rest-high-level-client side) that removed in PR opensearch-project#427 . * Replace with a new tagline "The OpenSearch Project: https://opensearch.org/". * Turn the tagline into a constant in server/src/main/java/org/opensearch/action/main/MainResponse.java. Signed-off-by: Tianli Feng <ftianli@amazon.com>
85313af
to
96e2cfa
Compare
✅ Gradle Wrapper Validation success 96e2cfa |
✅ DCO Check Passed 96e2cfa |
✅ Gradle Precommit success 96e2cfa |
start gradle check |
The test failure in log 295:
|
start gradle check |
start gradle check |
The test failure in log 295:
The above test failures aren't reproducible in my local machine. |
Description
Backport #913 (main) #914 (1.x) to
1.0
branch.server/src/main/java/org/opensearch/action/main/MainResponse.java
.After the change in the PR, the tagline field is back:
Issues Resolved
#901
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.