Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not evaluate shard_size and shard_min_doc_count at segment slice level #9085

Merged
merged 4 commits into from
Aug 9, 2023

Introduce LocalBucketCountThresholds for local size and min_doc_count…

3b55340
Select commit
Loading
Failed to load commit list.
Merged

Do not evaluate shard_size and shard_min_doc_count at segment slice level #9085

Introduce LocalBucketCountThresholds for local size and min_doc_count…
3b55340
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2023 in 0s

71.08% (target 70.00%)

View this Pull Request on Codecov

71.08% (target 70.00%)

Details

Codecov Report

Merging #9085 (3b55340) into main (6eb87b5) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 74.69%.

@@             Coverage Diff              @@
##               main    #9085      +/-   ##
============================================
- Coverage     71.10%   71.08%   -0.03%     
- Complexity    57326    57388      +62     
============================================
  Files          4768     4769       +1     
  Lines        270540   270542       +2     
  Branches      39559    39563       +4     
============================================
- Hits         192369   192305      -64     
- Misses        61966    62083     +117     
+ Partials      16205    16154      -51     
Files Changed Coverage Δ
.../search/aggregations/bucket/terms/DoubleTerms.java 76.92% <ø> (ø)
...ch/search/aggregations/bucket/terms/LongTerms.java 67.14% <ø> (ø)
.../search/aggregations/bucket/terms/StringTerms.java 85.71% <ø> (ø)
...h/aggregations/bucket/terms/UnsignedLongTerms.java 48.57% <ø> (ø)
...earch/search/aggregations/InternalAggregation.java 77.92% <33.33%> (+0.89%) ⬆️
...arch/aggregations/AggregationCollectorManager.java 77.77% <50.00%> (-4.99%) ⬇️
...ket/terms/GlobalOrdinalsStringTermsAggregator.java 79.57% <50.00%> (-0.22%) ⬇️
...rch/aggregations/bucket/terms/TermsAggregator.java 78.88% <50.00%> (-1.35%) ⬇️
...earch/aggregations/bucket/terms/InternalTerms.java 87.34% <61.53%> (-0.49%) ⬇️
...gations/bucket/terms/UnmappedSignificantTerms.java 33.33% <66.66%> (ø)
... and 17 more

... and 465 files with indirect coverage changes