Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client/sniffer from Javadoc exemption list #818

Merged

Conversation

gzurowski
Copy link
Contributor

@gzurowski gzurowski commented Jun 4, 2021

Signed-off-by: Gregor Zurowski gregor@zurowski.org

Description

All Javadoc errors were fixed in #802. This change removes client/sniffer from the Javadoc exemption list for the Gradle build.

Issues Resolved

Removing client/sniffer from exemption list as mentioned by @setiah in #802 (comment).

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gregor Zurowski <gregor@zurowski.org>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 76b8626

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 76b8626

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 76b8626

@setiah
Copy link
Contributor

setiah commented Jun 4, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 76b8626
Log 226

Reports 226

@setiah
Copy link
Contributor

setiah commented Jun 5, 2021

LGTM. thanks!

@setiah setiah merged commit 4fff570 into opensearch-project:main Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants