Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround to access Lucene's "expert" readLatestCommit API #7671

Merged

Conversation

kartg
Copy link
Member

@kartg kartg commented May 22, 2023

Description

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Related Issues

Resolves #7084

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kartg added 2 commits May 22, 2023 14:04
Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #7671 (8dab32e) into main (eb51f2b) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main    #7671      +/-   ##
============================================
+ Coverage     70.72%   70.75%   +0.03%     
- Complexity    56044    56051       +7     
============================================
  Files          4676     4676              
  Lines        265969   265965       -4     
  Branches      39061    39061              
============================================
+ Hits         188102   188191      +89     
+ Misses        61902    61794     -108     
- Partials      15965    15980      +15     
Impacted Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 70.09% <0.00%> (+0.32%) ⬆️
...main/java/org/opensearch/common/lucene/Lucene.java 73.93% <100.00%> (+1.22%) ⬆️
...va/org/opensearch/index/engine/ReadOnlyEngine.java 72.14% <100.00%> (ø)
...rc/main/java/org/opensearch/index/store/Store.java 79.51% <100.00%> (+0.42%) ⬆️

... and 468 files with indirect coverage changes

@andrross andrross added the backport 2.x Backport to 2.x branch label May 22, 2023
@andrross andrross merged commit 47d4f38 into opensearch-project:main May 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7671-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47d4f38eef90687943214e7c8847a3dacd968b1a
# Push it to GitHub
git push --set-upstream origin backport/backport-7671-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7671-to-2.x.

kartg added a commit to kartg/OpenSearch that referenced this pull request May 23, 2023
…pensearch-project#7671)

* Remove workaround to access Lucene's "expert" readLatestCommit API

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
(cherry picked from commit 47d4f38)
kartg added a commit that referenced this pull request May 23, 2023
…eadLatestCommit API (#7676)

* Remove workaround to access Lucene's "expert" readLatestCommit API (#7671)

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request May 23, 2023
…pensearch-project#7671)

* Remove workaround to access Lucene's "expert" readLatestCommit API

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Spotless run

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
…pensearch-project#7671)

* Remove workaround to access Lucene's "expert" readLatestCommit API

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Spotless run

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
…pensearch-project#7671)

* Remove workaround to access Lucene's "expert" readLatestCommit API

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Spotless run

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@kartg kartg deleted the snapshotExtendedCompat-removeWorkaround branch June 20, 2023 20:00
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pensearch-project#7671)

* Remove workaround to access Lucene's "expert" readLatestCommit API

Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Spotless run

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the workaround used to access Lucene's "expert" readLatestCommit API
2 participants