-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workaround to access Lucene's "expert" readLatestCommit API #7671
Merged
andrross
merged 2 commits into
opensearch-project:main
from
kartg:snapshotExtendedCompat-removeWorkaround
May 22, 2023
Merged
Remove workaround to access Lucene's "expert" readLatestCommit API #7671
andrross
merged 2 commits into
opensearch-project:main
from
kartg:snapshotExtendedCompat-removeWorkaround
May 22, 2023
+8
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
kartg
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
May 22, 2023 21:07
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
May 22, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7671 +/- ##
============================================
+ Coverage 70.72% 70.75% +0.03%
- Complexity 56044 56051 +7
============================================
Files 4676 4676
Lines 265969 265965 -4
Branches 39061 39061
============================================
+ Hits 188102 188191 +89
+ Misses 61902 61794 -108
- Partials 15965 15980 +15
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7671-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47d4f38eef90687943214e7c8847a3dacd968b1a
# Push it to GitHub
git push --set-upstream origin backport/backport-7671-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
kartg
added a commit
to kartg/OpenSearch
that referenced
this pull request
May 23, 2023
…pensearch-project#7671) * Remove workaround to access Lucene's "expert" readLatestCommit API Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Kartik Ganesh <gkart@amazon.com> (cherry picked from commit 47d4f38)
Merged
6 tasks
kartg
added a commit
that referenced
this pull request
May 23, 2023
…eadLatestCommit API (#7676) * Remove workaround to access Lucene's "expert" readLatestCommit API (#7671) Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com>
bharath-techie
pushed a commit
to bharath-techie/OpenSearch
that referenced
this pull request
May 23, 2023
…pensearch-project#7671) * Remove workaround to access Lucene's "expert" readLatestCommit API Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com> * Spotless run Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
suranjay
pushed a commit
to suranjay/OpenSearch
that referenced
this pull request
May 29, 2023
…pensearch-project#7671) * Remove workaround to access Lucene's "expert" readLatestCommit API Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com> * Spotless run Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Kartik Ganesh <gkart@amazon.com>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…pensearch-project#7671) * Remove workaround to access Lucene's "expert" readLatestCommit API Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com> * Spotless run Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Kartik Ganesh <gkart@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…pensearch-project#7671) * Remove workaround to access Lucene's "expert" readLatestCommit API Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required. Signed-off-by: Kartik Ganesh <gkart@amazon.com> * Spotless run Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lucene 9.6.0 includes changes to make the "expert" readLatestCommit API public, so the current code workaround using DirectoryReader is no longer required.
Related Issues
Resolves #7084
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.