Make file cache stats consistent with other APIs #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrross
requested review from
reta,
anasalkouz,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
dreamer-89
approved these changes
Apr 14, 2023
Gradle Check (Jenkins) Run Completed with:
|
kotwanikunal
approved these changes
Apr 14, 2023
Some cosmetic changes here to make the stat names consistent with [RequestCacheStats][1] and [QueryCacheStats][2] that already exist in the API. I've also removed the 'replaced' and 'removed' stats. These are internal cache details that I don't think will be useful to a user. We can always add them back later if needed. Note this is backward incompatible, but this is okay as this will get in ahead of the next release which removes the feature flag from searchable snapshots. [1]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/request/RequestCacheStats.java [2]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/query/QueryCacheStats.java Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
file-cache-stats-api-update
branch
from
4f1fcd7 to
e395c4a
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Known test failure: #6287 |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7169 +/- ##
============================================
- Coverage 70.67% 70.65% -0.02%
- Complexity 59457 59479 +22
============================================
Files 4852 4848 -4
Lines 285189 285146 -43
Branches 41118 41111 -7
============================================
- Hits 201564 201483 -81
- Misses 67042 67106 +64
+ Partials 16583 16557 -26
... and 516 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2023
Some cosmetic changes here to make the stat names consistent with [RequestCacheStats][1] and [QueryCacheStats][2] that already exist in the API. I've also removed the 'replaced' and 'removed' stats. These are internal cache details that I don't think will be useful to a user. We can always add them back later if needed. Note this is backward incompatible, but this is okay as this will get in ahead of the next release which removes the feature flag from searchable snapshots. [1]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/request/RequestCacheStats.java [2]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/query/QueryCacheStats.java Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 621b27f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Apr 17, 2023
Some cosmetic changes here to make the stat names consistent with [RequestCacheStats][1] and [QueryCacheStats][2] that already exist in the API. I've also removed the 'replaced' and 'removed' stats. These are internal cache details that I don't think will be useful to a user. We can always add them back later if needed. Note this is backward incompatible, but this is okay as this will get in ahead of the next release which removes the feature flag from searchable snapshots. [1]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/request/RequestCacheStats.java [2]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/query/QueryCacheStats.java (cherry picked from commit 621b27f) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…7169) Some cosmetic changes here to make the stat names consistent with [RequestCacheStats][1] and [QueryCacheStats][2] that already exist in the API. I've also removed the 'replaced' and 'removed' stats. These are internal cache details that I don't think will be useful to a user. We can always add them back later if needed. Note this is backward incompatible, but this is okay as this will get in ahead of the next release which removes the feature flag from searchable snapshots. [1]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/request/RequestCacheStats.java [2]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/cache/query/QueryCacheStats.java Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cosmetic changes here to make the stat names consistent with RequestCacheStats and QueryCacheStats that already exist in the API.
I've also removed the 'replaced' and 'removed' stats. These are internal cache details that I don't think will be useful to a user. We can always add them back later if needed.
Note this is backward incompatible, but this is okay as this will get in ahead of the next release which removes the feature flag from searchable snapshots.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.