Remove feature flag for searchable snapshots #7117

kotwanikunal · 2023-04-12T00:27:26Z

Description

Removes feature flag for searchable snapshots

Issues Resolved

Resolves [Searchable Snapshots] Remove feature flag gating for GA release #7115

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-04-12T00:32:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13909/
CommitID: f3aa643
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-04-12T02:16:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13914/
CommitID: f3aa643
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

andrross · 2023-04-12T17:25:39Z

Looks like some real test failures here:

andrross · 2023-04-12T17:26:55Z

.../main/java/org/opensearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java

@@ -146,7 +145,7 @@ public RestoreSnapshotRequest(StreamInput in) throws IOException {
        indexSettings = readSettingsFromStream(in);
        ignoreIndexSettings = in.readStringArray();
        snapshotUuid = in.readOptionalString();
-        if (FeatureFlags.isEnabled(FeatureFlags.SEARCHABLE_SNAPSHOT) && in.getVersion().onOrAfter(Version.V_2_4_0)) {
+        if (in.getVersion().onOrAfter(Version.V_2_4_0)) {


Due to the feature flag, 2.4 doesn't actually understand this field (by default). I think we'll have to change this to 3.0 in this PR, then change it to 2.7 after the backport.

It does mean the released version will be incompatible with the pre-release feature-flagged versions, which I think is probably fine.

Yep. I think we also need to update the V_3_0_0 references with V_2_7_0 later to have the correct BWC.

github-actions · 2023-04-12T18:11:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/13936/
CommitID: d630dd7
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-04-12T18:25:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.remotestore.CreateRemoteIndexTranslogDisabledIT.classMethod
      1 org.opensearch.remotestore.CreateRemoteIndexIT.testRemoteStoreDisabledByUser
      1 org.opensearch.remotestore.CreateRemoteIndexIT.classMethod

URL: https://build.ci.opensearch.org/job/gradle-check/13937/
CommitID: 224132b
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

andrross · 2023-04-12T20:02:33Z

Created issue #7128 for flaky failures in https://build.ci.opensearch.org/job/gradle-check/13937/

github-actions · 2023-04-12T20:34:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

URL: https://build.ci.opensearch.org/job/gradle-check/13950/
CommitID: 224132b
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

andrross · 2023-04-13T17:42:30Z

We should include a changelog entry announcing the feature as a part of this PR. Probably link to the meta issue.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

github-actions · 2023-04-13T18:24:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      2 org.opensearch.remotestore.CreateRemoteIndexClusterDefaultDocRep.classMethod
      1 org.opensearch.remotestore.CreateRemoteIndexTranslogDisabledIT.testRemoteStoreDisabledByUser

URL: https://build.ci.opensearch.org/job/gradle-check/14001/
CommitID: 56af808
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-04-13T18:32:24Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

URL: https://build.ci.opensearch.org/job/gradle-check/14002/
CommitID: af042e6
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

opensearch-trigger-bot · 2023-04-13T19:50:35Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7117-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c8421805955341ab692b003416b45b8d55ccd24
# Push it to GitHub
git push --set-upstream origin backport/backport-7117-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7117-to-2.x.

kotwanikunal · 2023-04-13T20:16:12Z

I'll take care of the backport.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> (cherry picked from commit 1c84218)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

kotwanikunal added the skip-changelog label Apr 12, 2023

kotwanikunal requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, gbbafna, setiah, kartg, mch2, nknize, owaiskazi19, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng, VachaShah and xuezhou25 as code owners April 12, 2023 00:27

kotwanikunal added the backport 2.x Backport to 2.x branch label Apr 12, 2023

andrross reviewed Apr 12, 2023

View reviewed changes

kotwanikunal force-pushed the feature-flag-removal branch 2 times, most recently from d630dd7 to 224132b Compare April 12, 2023 17:54

andrross added the v2.7.0 label Apr 12, 2023

andrross removed the skip-changelog label Apr 13, 2023

kotwanikunal force-pushed the feature-flag-removal branch from 224132b to 56af808 Compare April 13, 2023 17:54

Remove feature flag for searchable snapshots

af042e6

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

kotwanikunal force-pushed the feature-flag-removal branch from 56af808 to af042e6 Compare April 13, 2023 17:56

andrross approved these changes Apr 13, 2023

View reviewed changes

andrross merged commit 1c84218 into opensearch-project:main Apr 13, 2023

kotwanikunal added a commit to kotwanikunal/OpenSearch that referenced this pull request Apr 13, 2023

Remove feature flag for searchable snapshots (opensearch-project#7117)

b9b2c5c

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> (cherry picked from commit 1c84218)

This was referenced Apr 13, 2023

[Backport 2.x] Remove feature flag for searchable snapshots (#7117) #7150

Merged

[BUG] Searchable snapshot BWC support version needs to be V_2_7_0 on main #7151

Closed

andrross pushed a commit that referenced this pull request Apr 13, 2023

Remove feature flag for searchable snapshots (#7117) (#7150)

a960ec3

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> (cherry picked from commit 1c84218)

kotwanikunal mentioned this pull request Apr 14, 2023

[Segment Replication] Remove Segment Replication REPLICATION_TYPE feature flag. #7045

Merged

6 tasks

austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023

Remove feature flag for searchable snapshots (opensearch-project#7117)

8f13452

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>

kotwanikunal deleted the feature-flag-removal branch May 12, 2023 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove feature flag for searchable snapshots #7117

Remove feature flag for searchable snapshots #7117

kotwanikunal commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

andrross commented Apr 12, 2023

andrross Apr 12, 2023

andrross Apr 12, 2023

kotwanikunal Apr 12, 2023

github-actions bot commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

andrross commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

andrross commented Apr 13, 2023

github-actions bot commented Apr 13, 2023

github-actions bot commented Apr 13, 2023

opensearch-trigger-bot bot commented Apr 13, 2023

kotwanikunal commented Apr 13, 2023

Remove feature flag for searchable snapshots #7117

Remove feature flag for searchable snapshots #7117

Conversation

kotwanikunal commented Apr 12, 2023

Description

Issues Resolved

Check List

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

andrross commented Apr 12, 2023

andrross Apr 12, 2023

Choose a reason for hiding this comment

andrross Apr 12, 2023

Choose a reason for hiding this comment

kotwanikunal Apr 12, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

andrross commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

Gradle Check (Jenkins) Run Completed with:

andrross commented Apr 13, 2023

github-actions bot commented Apr 13, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Apr 13, 2023

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Apr 13, 2023

kotwanikunal commented Apr 13, 2023