Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid negative memory result in IndicesQueryCache stats calculation #6917

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Avoid negative memory result in IndicesQueryCache stats calculation #6917

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d171aba
Avoid negative memory result in IndicesQueryCache stats calculation
dbwiddis Mar 31, 2023
4e14768
Cache stores recent queries so isn't empty even with no doc id sets
dbwiddis Mar 31, 2023
a009248
Add test which actually fails without the bug fix
dbwiddis Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cache stores recent queries so isn't empty even with no doc id sets 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
  • Loading branch information
@dbwiddis
dbwiddis committed Apr 1, 2023
commit 4e14768211e76bc7bd5e9a708abb13ec5c4d0bc1
2 changes: 1 addition & 1 deletion server/src/test/java/org/opensearch/indices/IndicesQueryCacheTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public void testBasics() throws IOException {
assertEquals(0L, stats.getCacheCount());
assertEquals(0L, stats.getHitCount());
assertEquals(0L, stats.getMissCount());
assertEquals(0L, stats.getMemorySizeInBytes());
assertTrue(stats.getMemorySizeInBytes() >= 0L);

cache.close(); // this triggers some assertions
}
Expand Down