Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Fix Flaky Test SegmentReplicationRelocationIT #6675

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1e5d913 from #6637.

…estRelocateWhileContinuouslyIndexingAndWaitingForRefresh (#6637)

* Trigger Refresh on NRT Engine.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Revert changes made to PublishCheckpointAction in #6366

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Fix failing unit test

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Force flush on new elected primary after relocation.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Fix failing unit test.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Remove unnecessary assertions

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Adding tests.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Address comments

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Fix indentation.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
(cherry picked from commit 1e5d913)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Rishikesh1159 Rishikesh1159 changed the title [Backport 2.x] [Segment Replication] Fix Flaky Test SegmentReplicationRelocationIT.testRelocateWhileContinuouslyIndexingAndWaitingForRefresh [Backport 2.x] [Segment Replication] Fix Flaky Test SegmentReplicationRelocationIT Mar 15, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation

@codecov-commenter
Copy link

Codecov Report

Merging #6675 (b6649b6) into 2.x (b18cd49) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6675      +/-   ##
============================================
- Coverage     70.51%   70.50%   -0.01%     
- Complexity    59480    59507      +27     
============================================
  Files          4804     4804              
  Lines        285247   285250       +3     
  Branches      41463    41462       -1     
============================================
- Hits         201143   201117      -26     
- Misses        67337    67378      +41     
+ Partials      16767    16755      -12     
Impacted Files Coverage Δ
...eplication/checkpoint/PublishCheckpointAction.java 29.09% <10.00%> (+5.28%) ⬆️
.../opensearch/index/engine/NRTReplicationEngine.java 75.14% <33.33%> (-2.02%) ⬇️
...arch/index/engine/NRTReplicationReaderManager.java 88.46% <100.00%> (+0.96%) ⬆️
...nsearch/index/shard/CheckpointRefreshListener.java 100.00% <100.00%> (+11.11%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 68.92% <100.00%> (-0.49%) ⬇️

... and 467 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Rishikesh1159 Rishikesh1159 merged commit 1e30d68 into 2.x Mar 16, 2023
@github-actions github-actions bot deleted the backport/backport-6637-to-2.x branch March 16, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants