Speedup lang-painless tests #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Painless tests would previously create script engine for every single test method. Now the tests that need to tweak script engine settings create a class level fixture (BeforeClass/AfterClass) that is used across all the test methods in that suite. RegexLimitTests was split into two suites (limit=1 and limit=2) rather than dynamically applying different settings. C2 compiler is no longer needed for tests to be fast, instead tests run faster with C1 only as expected, like the rest of the unit tests. Signed-off-by: Robert Muir <rmuir@apache.org>
|
✅ Gradle Wrapper Validation success a0b5b27 |
|
✅ DCO Check Passed a0b5b27 |
|
✅ Gradle Precommit success a0b5b27 |
|
start gradle check |
|
Thanks @rmuir!!! These PRs are super important! Every performance improvement we can get with these tests are compounding productivity! |
rmuir
commented
Apr 23, 2021
| @@ -26,7 +26,7 @@ | |||
| */ | |||
|
|
|||
| /** | |||
| * Lexer, parser, and tree {@link Walker} responsible for turning the code | |||
| * Lexer, parser, and tree walker responsible for turning the code | |||
There was a problem hiding this comment.
fyi: these unrelated javadocs changes are just so that the module would compile in eclipse for me (it is picky by default about such stuff). I tried to avoid touching src/java in this PR, and I know eclipse is unsupported, but I use it for refactoring such as "rename method".
adnapibar
added
community
adnapibar
approved these changes
Apr 24, 2021
|
This has sat longer than it should've because of the release tagging. Merging and closing. |
nknize
added
pending backport
nknize
pushed a commit
to nknize/OpenSearch
that referenced
this pull request
Apr 27, 2021
Painless tests would previously create script engine for every single test method. Now the tests that need to tweak script engine settings create a class level fixture (BeforeClass/AfterClass) that is used across all the test methods in that suite. RegexLimitTests was split into two suites (limit=1 and limit=2) rather than dynamically applying different settings. C2 compiler is no longer needed for tests to be fast, instead tests run faster with C1 only as expected, like the rest of the unit tests. Signed-off-by: Robert Muir <rmuir@apache.org>
nknize
added a commit
that referenced
this pull request
Apr 28, 2021
Painless tests would previously create script engine for every single test method. Now the tests that need to tweak script engine settings create a class level fixture (BeforeClass/AfterClass) that is used across all the test methods in that suite. RegexLimitTests was split into two suites (limit=1 and limit=2) rather than dynamically applying different settings. C2 compiler is no longer needed for tests to be fast, instead tests run faster with C1 only as expected, like the rest of the unit tests. Signed-off-by: Robert Muir <rmuir@apache.org>
nknize
removed
the
pending backport
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
* Added "smartcn" analyzer. Signed-off-by: pieper <mike.pieper@ser.de> * Adapted changelog. Signed-off-by: pieper <mike.pieper@ser.de> * Fixed license headers. Signed-off-by: pieper <mike.pieper@ser.de> * Fixed release number. Signed-off-by: pieper <mike.pieper@ser.de> --------- Signed-off-by: pieper <mike.pieper@ser.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #580 to fix performance issues with
lang-painlesstests.There are ~1000 painless test methods and each one was inefficiently creating a new script engine (re-parsing whitelists and such).
On my machine the change gives ~ 2x speedup for the
lang-painlesstests.Now the tests that need to tweak script engine settings create a class level fixture (BeforeClass/AfterClass) that is used across all the test methods in that suite. It is also a conceptual simplification: all the test methods within a file use the same settings.
RegexLimitTests was split into two suites (limit=1 and limit=2) rather than dynamically applying different settings.
C2 compiler is no longer needed for tests to be fast, instead tests runfaster with C1 only as expected, like the rest of the unit tests.
Signed-off-by: Robert Muir rmuir@apache.org