Enable SearchableSnapshotIT to run during build #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrross
requested review from
reta,
anasalkouz,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
kotwanikunal
approved these changes
Jan 19, 2023
Gradle Check (Jenkins) Run Completed with:
|
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
enable-searchable-snapshot-integ-tests
branch
from
09b4d98 to
7d5bc15
Compare
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 19, 2023
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jan 20, 2023
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky: ``` run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT" ``` Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 901cd69) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test required the feature flag to be set as a system property, otherwise the test did nothing. This change programmatically sets the feature flag to allow the test to run during all builds. I ran the following command overnight (probably at least a couple thousand iterations) on a dev machine and saw no failures, so I have confidence this test is not flaky:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.