Removed unnecessary use of Long.toString from BlobStoreRepository. #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mani <singh.mani1231@gmail.com>
baba-devv
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5833 +/- ##
============================================
+ Coverage 70.81% 70.90% +0.08%
- Complexity 58686 58760 +74
============================================
Files 4768 4768
Lines 280575 280575
Branches 40514 40514
============================================
+ Hits 198685 198935 +250
+ Misses 65636 65349 -287
- Partials 16254 16291 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dblock
approved these changes
Jan 17, 2023
dblock
reviewed
Jan 17, 2023
| @@ -1820,7 +1820,7 @@ private RepositoryData getRepositoryData(long indexGen) { | |||
| return RepositoryData.EMPTY; | |||
| } | |||
| try { | |||
| final String snapshotsIndexBlobName = INDEX_FILE_PREFIX + Long.toString(indexGen); | |||
| final String snapshotsIndexBlobName = INDEX_FILE_PREFIX + indexGen; | |||
There was a problem hiding this comment.
I'm curious whether underneath it generates the same code? Do you know?
There was a problem hiding this comment.
Hi @dblock , most probably, yes, I've tested that out.
And thanks for merging this.
nknize
pushed a commit
to nknize/OpenSearch
that referenced
this pull request
Jan 19, 2023
…pensearch-project#5833) Signed-off-by: Mani <singh.mani1231@gmail.com>
andrross
pushed a commit
that referenced
this pull request
Jan 20, 2023
…5833) (#5911) Signed-off-by: Mani <singh.mani1231@gmail.com> (cherry picked from commit db30439) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mani <singh.mani1231@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
…5833) (#5911) Signed-off-by: Mani <singh.mani1231@gmail.com> (cherry picked from commit db30439) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mani <singh.mani1231@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mani singh.mani1231@gmail.com
Description
Removed unnecessary use of Long.toString from BlobStoreRepository.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.