Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Translog] Add support for downloading files from remote translog #5649

Merged
merged 12 commits into from
Jan 4, 2023
Merged

[Remote Translog] Add support for downloading files from remote translog #5649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3d8d0e8
Add support to download translog
Dec 27, 2022
c7681bb
Handle absence of remote translog repo
Dec 27, 2022
075d500
Address PR comments
Dec 29, 2022
7d4e454
Address PR comments
Dec 30, 2022
5c4970b
Address PR comments
Dec 30, 2022
385e859
Address PR comments
Jan 2, 2023
4c633d4
Fix spotless errors
Jan 2, 2023
f9316a8
Address PR comments
Jan 2, 2023
1be30a6
Address PR comments
Jan 2, 2023
7a9c32e
Address PR comments
Jan 3, 2023
032b022
Fix spotless errors
Jan 3, 2023
d2b2611
Checksum entire metadata file
Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spotless errors 
Signed-off-by: Sachin Kale <kalsac@amazon.com>
  • Loading branch information
Sachin Kale committed Jan 4, 2023
commit 032b022ba60a2e1c5e6c2bcb6bf7f09bb478848b
7 changes: 6 additions & 1 deletion server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@ public boolean transferSnapshot(TransferSnapshot transferSnapshot, TranslogTrans
}

public boolean downloadTranslog(String primaryTerm, String generation, Path location) throws IOException {
logger.info("Downloading translog files with: Primary Term = {}, Generation = {}, Location = {}", primaryTerm, generation, location);
logger.info(
"Downloading translog files with: Primary Term = {}, Generation = {}, Location = {}",
primaryTerm,
generation,
location
);
// Download Checkpoint file from remote to local FS
String ckpFileName = Translog.getCommitCheckpointFileName(Long.parseLong(generation));
downloadToFS(ckpFileName, location, primaryTerm);
Expand Down
2 changes: 0 additions & 2 deletions server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

package org.opensearch.index.translog.transfer;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.lucene.codecs.CodecUtil;
import org.apache.lucene.store.DataOutput;
import org.apache.lucene.store.InputStreamDataInput;
Expand Down