-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport-2.x] Refactor fuzziness interface on query builders (#5433) #5584
Merged
reta
merged 1 commit into
opensearch-project:2.x
from
noCharger:backport/backport-5433-to-2.x
Dec 15, 2022
Merged
[Backport-2.x] Refactor fuzziness interface on query builders (#5433) #5584
reta
merged 1 commit into
opensearch-project:2.x
from
noCharger:backport/backport-5433-to-2.x
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor Object to Fuzziness type for all query builders Signed-off-by: noCharger <lingzhichu.clz@gmail.com> * Revise on bwc Signed-off-by: noCharger <lingzhichu.clz@gmail.com> * Update change log Signed-off-by: noCharger <lingzhichu.clz@gmail.com> Signed-off-by: noCharger <lingzhichu.clz@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> (cherry picked from commit d3f6dfa) Signed-off-by: Louis Chu <clingzhi@amazon.com>
noCharger
force-pushed
the
backport/backport-5433-to-2.x
branch
from
December 15, 2022 17:36
9097b4c
to
1c65505
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #5584 +/- ##
============================================
- Coverage 70.65% 70.59% -0.06%
+ Complexity 58408 58385 -23
============================================
Files 4716 4716
Lines 279707 279711 +4
Branches 40819 40817 -2
============================================
- Hits 197621 197466 -155
- Misses 65579 65808 +229
+ Partials 16507 16437 -70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
noCharger
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
December 15, 2022 18:54
reta
approved these changes
Dec 15, 2022
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Refactor Object to Fuzziness type for all query builders Signed-off-by: noCharger <lingzhichu.clz@gmail.com> * Revise on bwc Signed-off-by: noCharger <lingzhichu.clz@gmail.com> * Update change log Signed-off-by: noCharger <lingzhichu.clz@gmail.com> Signed-off-by: noCharger <lingzhichu.clz@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> (cherry picked from commit d3f6dfa) Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: noCharger <lingzhichu.clz@gmail.com> Signed-off-by: Louis Chu <clingzhi@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fuzziness interface on query builders (#5433)
(cherry picked from commit d3f6dfa)
Signed-off-by: noCharger lingzhichu.clz@gmail.com
Description
[Backport-2.x] Refactor fuzziness interface on query builders (#5433)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.