Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-2.x] Refactor fuzziness interface on query builders (#5433) #5584

Merged

Conversation

noCharger
Copy link
Contributor

@noCharger noCharger commented Dec 15, 2022

Refactor fuzziness interface on query builders (#5433)
(cherry picked from commit d3f6dfa)
Signed-off-by: noCharger lingzhichu.clz@gmail.com

Description

[Backport-2.x] Refactor fuzziness interface on query builders (#5433)

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Refactor Object to Fuzziness type for all query builders

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

* Revise on bwc

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

* Update change log

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit d3f6dfa)
Signed-off-by: Louis Chu <clingzhi@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

@codecov-commenter
Copy link

Codecov Report

Merging #5584 (1c65505) into 2.x (4f26823) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #5584      +/-   ##
============================================
- Coverage     70.65%   70.59%   -0.06%     
+ Complexity    58408    58385      -23     
============================================
  Files          4716     4716              
  Lines        279707   279711       +4     
  Branches      40819    40817       -2     
============================================
- Hits         197621   197466     -155     
- Misses        65579    65808     +229     
+ Partials      16507    16437      -70     
Impacted Files Coverage Δ
...ain/java/org/opensearch/common/unit/Fuzziness.java 84.53% <100.00%> (-1.93%) ⬇️
...earch/index/query/MatchBoolPrefixQueryBuilder.java 87.22% <100.00%> (-1.12%) ⬇️
.../org/opensearch/index/query/MatchQueryBuilder.java 86.59% <100.00%> (-1.11%) ⬇️
...opensearch/index/query/MultiMatchQueryBuilder.java 81.05% <100.00%> (-0.40%) ⬇️
...pensearch/index/query/QueryStringQueryBuilder.java 89.47% <100.00%> (+0.21%) ⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-73.18%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-56.25%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
... and 504 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit 4ab6082 into opensearch-project:2.x Dec 15, 2022
@macohen macohen added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 20, 2022
@macohen macohen removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 20, 2022
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
* Refactor Object to Fuzziness type for all query builders

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

* Revise on bwc

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

* Update change log

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit d3f6dfa)
Signed-off-by: Louis Chu <clingzhi@amazon.com>

Signed-off-by: noCharger <lingzhichu.clz@gmail.com>
Signed-off-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants