Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance CheckpointState to support no-op replication #5447

Closed
wants to merge 20 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add PerformOnReplicaProxy for extensibility in replication flow
Signed-off-by: Ashish Singh <ssashish@amazon.com>
  • Loading branch information
ashking94 committed Dec 2, 2022
commit 73113e1651c3fb5518832b30e68fe06331717f7c
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,55 @@ private void performOnReplicas(
final ShardRouting primaryRouting = primary.routingEntry();

for (final ReplicationAwareShardRouting shardRouting : replicationGroup.getReplicationTargets()) {
ShardRouting shard = shardRouting.getShardRouting();
if (!shard.isSameAllocation(primaryRouting)
&& (shardRouting.isReplicated() || (shardRouting.isRemoteTranslogEnabled() && forceReplicationIfRemoteTranslogEnabled))) {
performOnReplica(shard, replicaRequest, globalCheckpoint, maxSeqNoOfUpdatesOrDeletes, pendingReplicationActions);
new PerformOnReplicaProxyFactory().create(
primaryRouting,
shardRouting,
replicaRequest,
globalCheckpoint,
maxSeqNoOfUpdatesOrDeletes,
replicationGroup,
pendingReplicationActions
).run();
}
}

interface PerformOnReplicaProxy extends Runnable {}

private class PerformOnReplicaProxyFactory {
PerformOnReplicaProxy create(
final ShardRouting primaryRouting,
final ReplicationAwareShardRouting shardRouting,
final ReplicaRequest replicaRequest,
final long globalCheckpoint,
final long maxSeqNoOfUpdatesOrDeletes,
final ReplicationGroup replicationGroup,
final PendingReplicationActions pendingReplicationActions
) {
if (needsReplication(primaryRouting, shardRouting, forceReplicationIfRemoteTranslogEnabled)) {
return () -> {
performOnReplica(
shardRouting.getShardRouting(),
replicaRequest,
globalCheckpoint,
maxSeqNoOfUpdatesOrDeletes,
pendingReplicationActions
);
};
}
return () -> {};
}
}

private static boolean needsReplication(
ShardRouting primaryRouting,
ReplicationAwareShardRouting shardRouting,
boolean forceReplication
) {
ShardRouting shard = shardRouting.getShardRouting();
return !shard.isSameAllocation(primaryRouting)
&& (shardRouting.isReplicated() || (shardRouting.isRemoteTranslogEnabled() && forceReplication));
}

private void performOnReplica(
final ShardRouting shard,
final ReplicaRequest replicaRequest,
Expand Down