Cleanup unused code in org.opensearch.common.lucene #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
reta
reviewed
Nov 18, 2022
|
|
||
| import static org.hamcrest.Matchers.equalTo; | ||
|
|
||
| public class LuceneTests extends OpenSearchTestCase { | ||
| private static final NamedWriteableRegistry EMPTY_REGISTRY = new NamedWriteableRegistry(Collections.emptyList()); | ||
|
|
||
| public void testWaitForIndex() throws Exception { |
There was a problem hiding this comment.
The test is for Lucene.waitForIndex() which is not used anywhere.
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5306 +/- ##
============================================
+ Coverage 70.98% 71.10% +0.11%
- Complexity 58121 58167 +46
============================================
Files 4704 4704
Lines 277312 277266 -46
Branches 40149 40147 -2
============================================
+ Hits 196854 197145 +291
+ Misses 64356 63975 -381
- Partials 16102 16146 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup unused internal code in the
o.o.common.lucenepackageIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com