Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Fix error handling while reading analyzer mapping rules #5123

Closed
wants to merge 1 commit into from
Closed

[Backport 2.4] Fix error handling while reading analyzer mapping rules #5123

wants to merge 1 commit into from

Conversation

adnapibar
Copy link
Contributor

backport 6d20423 to 2.4

Signed-off-by: Rabi Panda adnapibar@gmail.com

Description

Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@adnapibar adnapibar added the backport 2.4 Backport to 2.4 branch label Nov 8, 2022
@adnapibar adnapibar requested review from a team and reta as code owners November 8, 2022 01:43
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@adnapibar adnapibar changed the title [Backport] Fix error handling while reading analyzer mapping rules [Backport 2.4] Fix error handling while reading analyzer mapping rules Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@adnapibar adnapibar removed the backport 2.4 Backport to 2.4 branch label Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 8, 2022

Hi @adnapibar need rebase on main to consume changes in #5127

@peterzhuamazon
Copy link
Member

Will still having issue until all the branches are backported with #5127

Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Nov 8, 2022

@mch2 and I are working on fixing CI for bcw all the way back from 1.3.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Trying to get a passing build in #5142.

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Merged #5141

@dblock dblock closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants