Skip to content

Conversation

@nknize
Copy link
Contributor

@nknize nknize commented Oct 19, 2022

Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version constants along with ancient API logic.

relates #2747

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 19, 2022
@nknize nknize requested review from a team and reta as code owners October 19, 2022 15:03
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Contributor Author

nknize commented Oct 19, 2022

Oh fun! Looks like we have a race condition in IndexShardIT.testIndexCanChangeCustomDataPath.

deleteReaderFiles must be getting called async before the test finishes copying.

[2022-10-19T08:21:35,640][ERROR][o.o.i.s.IndexShardIT     ] [testIndexCanChangeCustomDataPath] Failed to copy data path directory
java.nio.file.NoSuchFileException: /var/jenkins/workspace/gradle-check/search/server/build/testrun/internalClusterTest/temp/org.opensearch.index.shard.IndexShardIT_B9157C425F286EBE-001/rxeTWWtHeW/start-KZvCXclcHt/0/ipMqHwdkRym5TzwG0a3ubg/0/translog/translog-3794781907109570892.ckp

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

❌ Patch coverage is 68.58974% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.90%. Comparing base (db418fb) to head (2692841).
⚠️ Report is 3728 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/test/rest/OpenSearchRestTestCase.java 0.00% 14 Missing ⚠️
...ch/analysis/common/CommonAnalysisModulePlugin.java 0.00% 7 Missing and 1 partial ⚠️
.../node/reload/NodesReloadSecureSettingsRequest.java 0.00% 7 Missing ⚠️
...tion/admin/cluster/stats/ClusterStatsResponse.java 0.00% 6 Missing ⚠️
...on/admin/indices/forcemerge/ForceMergeRequest.java 20.00% 4 Missing ⚠️
...ateway/TransportNodesListGatewayStartedShards.java 40.00% 2 Missing and 1 partial ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 40.00% 2 Missing and 1 partial ⚠️
...pensearch/cluster/metadata/AutoExpandReplicas.java 75.00% 0 Missing and 1 partial ⚠️
...org/opensearch/index/seqno/ReplicationTracker.java 50.00% 0 Missing and 1 partial ⚠️
...rg/opensearch/indices/analysis/AnalysisModule.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4837      +/-   ##
============================================
+ Coverage     70.87%   70.90%   +0.03%     
+ Complexity    57922    57884      -38     
============================================
  Files          4692     4692              
  Lines        276852   276648     -204     
  Branches      40236    40157      -79     
============================================
- Hits         196212   196151      -61     
+ Misses        64458    64314     -144     
- Partials      16182    16183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Oct 21, 2022

I believe this has been fixed in #4270, rebase?

@nknize nknize force-pushed the remove/7677VersionConstants branch from a317763 to 6bfadbb Compare October 21, 2022 16:43
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version
constants along with ancient API logic.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the remove/7677VersionConstants branch from 6bfadbb to 1f533a0 Compare November 1, 2022 12:32
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit fab4336 into opensearch-project:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants