Validating fuzziness value in query #4748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subramanian S <subbu.dvk0@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
|
@subbudvk, |
Sure. Are these changes fine? I'll add tests shortly. @Yury-Fridlyand |
Signed-off-by: Subramanian S <subbu.dvk0@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
|
@subbudvk Do you need any help on get the ball rolling on this PR, such as adding the unit test or need more eyes on reviewing it? |
|
@macohen could you please help with this PR? |
|
Closing, issue was fixed in #5805. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Subramanian S subbu.dvk0@gmail.com
Description
Validated fuzziness values are only positive integers, AUTO or AUTO:int,int
Issues Resolved
Issue 4223
Check List
Tested positive integers, AUTO, AUTO:int,int cases, working as expected.
Other illegal values throw error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.